Re: [PATCH 2/3] tpm: Get rid of chip->pdev

From	Jason Gunthorpe <jgunthorpe@obsidianresearch.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH 2/3] tpm: Get rid of chip->pdev
Date	2016-02-14 08:00 +0100
Message-ID	<r1YP0-7Co-1@gated-at.bofh.it> (permalink)
References	(2 earlier) <r1x2q-6qn-21@gated-at.bofh.it> <r1x2q-6qn-19@gated-at.bofh.it> <r1xOO-6Xr-3@gated-at.bofh.it> <r1zdT-7MB-5@gated-at.bofh.it> <r1XpT-6Qc-1@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Sun, Feb 14, 2016 at 07:24:14AM +0200, Jarkko Sakkinen wrote:
> > This should take care of it for all drivers including vtpm.
> > 
> > https://github.com/jgunthorpe/linux/commits/for-jarkko
> > 
> > At the very least this turns silent use after free into a null pointer
> > oops.
> > 
> > We should also discuss if we want to continue to have the driver
> > module locked while /dev/tpmX is open, that is no longer needed for
> > corectness.
> 
> I'm happy the patch that was sent before although I didn't give it
> Reviewed-by because it had couple of style errors. If those two
> style errors are the *only* issues I can fix up them.

This patch replaces the get/put_device patch entirely, if Stefan is
happy with it we can just go ahead in this direction for 4.6

There was also a 0day build error on the devname patch, so the whole
series will be reposted.

Jason

Thread

[PATCH 0/3] Various struct device cleanups Jason Gunthorpe <jgunthorpe@obsidianresearch.com> - 2016-02-13 01:10 +0100
  [PATCH 1/3] tpm: Hold the kref during tpm_chip_find_get Jason Gunthorpe <jgunthorpe@obsidianresearch.com> - 2016-02-13 01:10 +0100
    Re: [PATCH 1/3] tpm: Hold the kref during tpm_chip_find_get Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com> - 2016-02-13 11:10 +0100
      Re: [PATCH 1/3] tpm: Hold the kref during tpm_chip_find_get Jason Gunthorpe <jgunthorpe@obsidianresearch.com> - 2016-02-13 16:50 +0100
    Re: [PATCH 1/3] tpm: Hold the kref during tpm_chip_find_get Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com> - 2016-02-14 06:00 +0100
      Re: [PATCH 1/3] tpm: Hold the kref during tpm_chip_find_get Jason Gunthorpe <jgunthorpe@obsidianresearch.com> - 2016-02-14 08:00 +0100
        Re: [PATCH 1/3] tpm: Hold the kref during tpm_chip_find_get Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com> - 2016-02-14 09:10 +0100
  [PATCH 3/3] tpm: Get rid of devname Jason Gunthorpe <jgunthorpe@obsidianresearch.com> - 2016-02-13 01:10 +0100
    Re: [PATCH 3/3] tpm: Get rid of devname Jason Gunthorpe <jgunthorpe@obsidianresearch.com> - 2016-02-13 02:20 +0100
    Re: [PATCH 3/3] tpm: Get rid of devname Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com> - 2016-02-14 06:20 +0100
  [PATCH 2/3] tpm: Get rid of chip->pdev Jason Gunthorpe <jgunthorpe@obsidianresearch.com> - 2016-02-13 01:10 +0100
    Re: [PATCH 2/3] tpm: Get rid of chip->pdev Jason Gunthorpe <jgunthorpe@obsidianresearch.com> - 2016-02-13 02:20 +0100
      Re: [PATCH 2/3] tpm: Get rid of chip->pdev Jason Gunthorpe <jgunthorpe@obsidianresearch.com> - 2016-02-13 03:10 +0100
      Re: [PATCH 2/3] tpm: Get rid of chip->pdev Jason Gunthorpe <jgunthorpe@obsidianresearch.com> - 2016-02-13 04:40 +0100
        Re: [PATCH 2/3] tpm: Get rid of chip->pdev Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com> - 2016-02-14 06:30 +0100
          Re: [PATCH 2/3] tpm: Get rid of chip->pdev Jason Gunthorpe <jgunthorpe@obsidianresearch.com> - 2016-02-14 08:00 +0100
            Re: [PATCH 2/3] tpm: Get rid of chip->pdev Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com> - 2016-02-14 09:10 +0100
    Re: [tpmdd-devel] [PATCH 2/3] tpm: Get rid of chip->pdev Stefan Berger <stefanb@linux.vnet.ibm.com> - 2016-02-13 16:50 +0100
      Re: [tpmdd-devel] [PATCH 2/3] tpm: Get rid of chip->pdev Jason Gunthorpe <jgunthorpe@obsidianresearch.com> - 2016-02-14 08:10 +0100
    Re: [PATCH 2/3] tpm: Get rid of chip->pdev Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com> - 2016-02-14 06:20 +0100

csiph-web