Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1333334

Re: [tpmdd-devel] [PATCH 2/3] tpm: Get rid of chip->pdev

Show all headers | View raw

On 02/12/2016 07:04 PM, Jason Gunthorpe wrote:
> This is a hold over from before the struct device conversion.
>
> - All prints should be using &chip->dev, which is the Linux
>    standard. This changes prints to use tpm0 as the device name,
>    not the PnP/etc ID.
> - The few places involving sysfs/modules that really do need the
>    parent just use chip->dev.parent instead
> - We no longer need to get_device(pdev) in any places since it is no
>    longer used by any of the code. The kref on the parent is held
>    by the device core during device_add and dropped in device_del
>
> Signed-off-by: Jason Gunthorpe <jgunthorpe@obsidianresearch.com>
> ---

> @@ -347,8 +347,8 @@ static int i2c_nuvoton_recv(struct tpm_chip *chip, u8 *buf, size_t count)
>    */
>   static int i2c_nuvoton_send(struct tpm_chip *chip, u8 *buf, size_t len)
>   {
> -	struct device *dev = chip->pdev;
> -	struct i2c_client *client = to_i2c_client(dev);
> +	struct device *dev = &chip->dev;
This looks wrong or are you fixing a bug here? chip->dev.parent ?
> +	struct i2c_client *client = to_i2c_client(chip->dev.parent);

Does this need to be replaced ?

     Stefan

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH 0/3] Various struct device cleanups Jason Gunthorpe <jgunthorpe@obsidianresearch.com> - 2016-02-13 01:10 +0100
  [PATCH 1/3] tpm: Hold the kref during tpm_chip_find_get Jason Gunthorpe <jgunthorpe@obsidianresearch.com> - 2016-02-13 01:10 +0100
    Re: [PATCH 1/3] tpm: Hold the kref during tpm_chip_find_get Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com> - 2016-02-13 11:10 +0100
      Re: [PATCH 1/3] tpm: Hold the kref during tpm_chip_find_get Jason Gunthorpe <jgunthorpe@obsidianresearch.com> - 2016-02-13 16:50 +0100
    Re: [PATCH 1/3] tpm: Hold the kref during tpm_chip_find_get Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com> - 2016-02-14 06:00 +0100
      Re: [PATCH 1/3] tpm: Hold the kref during tpm_chip_find_get Jason Gunthorpe <jgunthorpe@obsidianresearch.com> - 2016-02-14 08:00 +0100
        Re: [PATCH 1/3] tpm: Hold the kref during tpm_chip_find_get Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com> - 2016-02-14 09:10 +0100
  [PATCH 3/3] tpm: Get rid of devname Jason Gunthorpe <jgunthorpe@obsidianresearch.com> - 2016-02-13 01:10 +0100
    Re: [PATCH 3/3] tpm: Get rid of devname Jason Gunthorpe <jgunthorpe@obsidianresearch.com> - 2016-02-13 02:20 +0100
    Re: [PATCH 3/3] tpm: Get rid of devname Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com> - 2016-02-14 06:20 +0100
  [PATCH 2/3] tpm: Get rid of chip->pdev Jason Gunthorpe <jgunthorpe@obsidianresearch.com> - 2016-02-13 01:10 +0100
    Re: [PATCH 2/3] tpm: Get rid of chip->pdev Jason Gunthorpe <jgunthorpe@obsidianresearch.com> - 2016-02-13 02:20 +0100
      Re: [PATCH 2/3] tpm: Get rid of chip->pdev Jason Gunthorpe <jgunthorpe@obsidianresearch.com> - 2016-02-13 03:10 +0100
      Re: [PATCH 2/3] tpm: Get rid of chip->pdev Jason Gunthorpe <jgunthorpe@obsidianresearch.com> - 2016-02-13 04:40 +0100
        Re: [PATCH 2/3] tpm: Get rid of chip->pdev Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com> - 2016-02-14 06:30 +0100
          Re: [PATCH 2/3] tpm: Get rid of chip->pdev Jason Gunthorpe <jgunthorpe@obsidianresearch.com> - 2016-02-14 08:00 +0100
            Re: [PATCH 2/3] tpm: Get rid of chip->pdev Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com> - 2016-02-14 09:10 +0100
    Re: [tpmdd-devel] [PATCH 2/3] tpm: Get rid of chip->pdev Stefan Berger <stefanb@linux.vnet.ibm.com> - 2016-02-13 16:50 +0100
      Re: [tpmdd-devel] [PATCH 2/3] tpm: Get rid of chip->pdev Jason Gunthorpe <jgunthorpe@obsidianresearch.com> - 2016-02-14 08:10 +0100
    Re: [PATCH 2/3] tpm: Get rid of chip->pdev Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com> - 2016-02-14 06:20 +0100

csiph-web