Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1333298

Re: [PATCH 2/3] ibmveth: Return correct error codes

From David Miller <davem@davemloft.net>
Newsgroups linux.kernel
Subject Re: [PATCH 2/3] ibmveth: Return correct error codes
Date 2016-02-13 12:00 +0100
Message-ID <r1G5J-3Bz-13@gated-at.bofh.it> (permalink)
References <qYsBY-W2-21@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


From: Amitoj Kaur Chawla <amitoj1606@gmail.com>
Date: Thu, 4 Feb 2016 19:25:19 +0530

> The return value of kmalloc and kcalloc on failure of allocation of
> memory should be -ENOMEM and not -1.
> 
> Found using Coccinelle. A simplified version of the semantic patch
> used is:
 ...
> The two call sites only check that the return value is not 0,
> hence no change is required at the call sites.
> 
> Signed-off-by: Amitoj Kaur Chawla <amitoj1606@gmail.com>

This does not apply cleanly and gives rejects.

Back to linux.kernel | Previous | Next | Find similar | Unroll thread


Thread

Re: [PATCH 2/3] ibmveth: Return correct error codes David Miller <davem@davemloft.net> - 2016-02-13 12:00 +0100

csiph-web