Re: [PATCH 1/3] net: cavium: liquidio: Return correct error code

From	David Miller <davem@davemloft.net>
Newsgroups	linux.kernel
Subject	Re: [PATCH 1/3] net: cavium: liquidio: Return correct error code
Date	2016-02-13 12:00 +0100
Message-ID	<r1G5I-3Bz-7@gated-at.bofh.it> (permalink)
References	<qYsBY-W2-3@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

From: Amitoj Kaur Chawla <amitoj1606@gmail.com>
Date: Thu, 4 Feb 2016 19:25:13 +0530

> The return value of vmalloc on failure of allocation of memory should
> be -ENOMEM and not -1.
> 
> Found using Coccinelle. A simplified version of the semantic patch
> used is:
 ...
> The single call site of the containing function checks whether the
> returned value is -1, so this check is changed as well. The single call 
> site of this call site, however, only checks whether the value is not 0,
> so no further change was required.
> 
> Signed-off-by: Amitoj Kaur Chawla <amitoj1606@gmail.com>

Applied.

Back to linux.kernel | Previous | Next | Find similar | Unroll thread

Thread

Re: [PATCH 1/3] net: cavium: liquidio: Return correct error code David Miller <davem@davemloft.net> - 2016-02-13 12:00 +0100

csiph-web