Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1330425
| From | Robin Murphy <robin.murphy@arm.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH] of/irq: Fix msi-map calculation for nonzero rid-base |
| Date | 2016-02-09 17:20 +0100 |
| Message-ID | <r0jbe-6vm-51@gated-at.bofh.it> (permalink) |
| References | <r0elc-3c6-21@gated-at.bofh.it> <r0fhg-3Ov-5@gated-at.bofh.it> <r0j1w-6qX-7@gated-at.bofh.it> <r0j1w-6qX-5@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On 09/02/16 16:08, Mark Rutland wrote:
[...]
>>>> having msi-map-mask clash with a nonzero rid-base, as that's another
>>>> thing one can easily get wrong.
[...]
>>>> + if (rid_base & ~map_mask) {
>>>> + dev_err(parent_dev,
>>>> + "Invalid msi-map translation - msi-map-mask (0x%x) ignores rid-
>>> base (0x%x)\n",
>>>> + map_mask, rid_base);
>>>> + return rid_out;
>>>> + }
[...]
>> msi-map = <0x0100 &its 0x11 0x1>;
>> msi-map-mask = <0xff>;
>>
>
> I'd say that this is an inconsistent set of properties, and it's
> probably worth warning if we encounter this. There is no possible way
> that rid-base can be encountered.
Indeed ;)
Robin.
> Thanks,
> Mark.
>
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH] of/irq: Fix msi-map calculation for nonzero rid-base Robin Murphy <robin.murphy@arm.com> - 2016-02-09 12:10 +0100
Re: [PATCH] of/irq: Fix msi-map calculation for nonzero rid-base Marc Zyngier <marc.zyngier@arm.com> - 2016-02-09 13:10 +0100
Re: [PATCH] of/irq: Fix msi-map calculation for nonzero rid-base Mark Rutland <mark.rutland@arm.com> - 2016-02-09 17:10 +0100
Re: [PATCH] of/irq: Fix msi-map calculation for nonzero rid-base Robin Murphy <robin.murphy@arm.com> - 2016-02-09 17:20 +0100
Re: [PATCH] of/irq: Fix msi-map calculation for nonzero rid-base Mark Rutland <mark.rutland@arm.com> - 2016-02-09 19:30 +0100
RE: [PATCH] of/irq: Fix msi-map calculation for nonzero rid-base Stuart Yoder <stuart.yoder@nxp.com> - 2016-02-09 18:00 +0100
RE: [PATCH] of/irq: Fix msi-map calculation for nonzero rid-base Stuart Yoder <stuart.yoder@nxp.com> - 2016-02-09 17:40 +0100
Re: [PATCH] of/irq: Fix msi-map calculation for nonzero rid-base David Daney <ddaney@caviumnetworks.com> - 2016-02-09 18:10 +0100
RE: [PATCH] of/irq: Fix msi-map calculation for nonzero rid-base Stuart Yoder <stuart.yoder@nxp.com> - 2016-02-09 19:20 +0100
Re: [PATCH] of/irq: Fix msi-map calculation for nonzero rid-base Marc Zyngier <marc.zyngier@arm.com> - 2016-02-11 12:10 +0100
Re: [PATCH] of/irq: Fix msi-map calculation for nonzero rid-base Frank Rowand <frowand.list@gmail.com> - 2016-02-11 19:20 +0100
Re: [PATCH] of/irq: Fix msi-map calculation for nonzero rid-base Rob Herring <robh+dt@kernel.org> - 2016-02-12 00:20 +0100
Re: [PATCH] of/irq: Fix msi-map calculation for nonzero rid-base Marc Zyngier <marc.zyngier@arm.com> - 2016-02-12 09:40 +0100
csiph-web