Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1331822

Re: [PATCH] of/irq: Fix msi-map calculation for nonzero rid-base

Show all headers | View raw

On 09/02/16 11:04, Robin Murphy wrote:
> The existing msi-map code is fine for shifting the entire RID space
> upwards, but attempting finer-grained remapping reveals a bug. It turns
> out that we are mistakenly treating the msi-base part as an offset, not
> as a new base to remap onto, so things get squiffy when rid-base is
> nonzero. Fix this, and at the same time add a sanity check against
> having msi-map-mask clash with a nonzero rid-base, as that's another
> thing one can easily get wrong.
> 
> CC: <stable@vger.kernel.org>
> Signed-off-by: Robin Murphy <robin.murphy@arm.com>

Rob, Frank,

Are you willing to take this one through the OF tree? Or should we route
it through the IRQ tree? It'd be good if it make it into 4.5.

Thanks,

	M.
-- 
Jazz is not dead. It just smells funny...

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH] of/irq: Fix msi-map calculation for nonzero rid-base Robin Murphy <robin.murphy@arm.com> - 2016-02-09 12:10 +0100
  Re: [PATCH] of/irq: Fix msi-map calculation for nonzero rid-base Marc Zyngier <marc.zyngier@arm.com> - 2016-02-09 13:10 +0100
    Re: [PATCH] of/irq: Fix msi-map calculation for nonzero rid-base Mark Rutland <mark.rutland@arm.com> - 2016-02-09 17:10 +0100
      Re: [PATCH] of/irq: Fix msi-map calculation for nonzero rid-base Robin Murphy <robin.murphy@arm.com> - 2016-02-09 17:20 +0100
        Re: [PATCH] of/irq: Fix msi-map calculation for nonzero rid-base Mark Rutland <mark.rutland@arm.com> - 2016-02-09 19:30 +0100
      RE: [PATCH] of/irq: Fix msi-map calculation for nonzero rid-base Stuart Yoder <stuart.yoder@nxp.com> - 2016-02-09 18:00 +0100
    RE: [PATCH] of/irq: Fix msi-map calculation for nonzero rid-base Stuart Yoder <stuart.yoder@nxp.com> - 2016-02-09 17:40 +0100
  Re: [PATCH] of/irq: Fix msi-map calculation for nonzero rid-base David Daney <ddaney@caviumnetworks.com> - 2016-02-09 18:10 +0100
  RE: [PATCH] of/irq: Fix msi-map calculation for nonzero rid-base Stuart Yoder <stuart.yoder@nxp.com> - 2016-02-09 19:20 +0100
  Re: [PATCH] of/irq: Fix msi-map calculation for nonzero rid-base Marc Zyngier <marc.zyngier@arm.com> - 2016-02-11 12:10 +0100
    Re: [PATCH] of/irq: Fix msi-map calculation for nonzero rid-base Frank Rowand <frowand.list@gmail.com> - 2016-02-11 19:20 +0100
    Re: [PATCH] of/irq: Fix msi-map calculation for nonzero rid-base Rob Herring <robh+dt@kernel.org> - 2016-02-12 00:20 +0100
      Re: [PATCH] of/irq: Fix msi-map calculation for nonzero rid-base Marc Zyngier <marc.zyngier@arm.com> - 2016-02-12 09:40 +0100

csiph-web