Re: [PATCH v3 01/12] irqchip: armada-370-xp: add Kconfig option for the driver

From	Arnd Bergmann <arnd@arndb.de>
Newsgroups	linux.kernel
Subject	Re: [PATCH v3 01/12] irqchip: armada-370-xp: add Kconfig option for the driver
Date	2016-02-09 16:20 +0100
Message-ID	<r0if8-5Nd-25@gated-at.bofh.it> (permalink)
References	<qZXDH-8ih-5@gated-at.bofh.it> <qZXDI-8ih-23@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Monday 08 February 2016 18:14:09 Gregory CLEMENT wrote:
> 
> +config ARMADA_370_XP_IRQ
> +       bool
> +       default y if ARCH_MVEBU
> +       select GENERIC_IRQ_CHIP
> +
> 

Looks good. I wonder if we should also enable this for COMPILE_TEST, e.g.

config ARMADA_370_XP_IRQ
       bool "Marvell Armada 3xx/XP/3xxx interrupt controller" if COMPILE_TEST && !ARCH_MVEBU
       default ARCH_MVEBU
       select GENERIC_IRQ_CHIP

If we do this, it's probably something outside of your series that we should
do for all patches, so don't worry about it here. Any opinions on the general
question?

	Arnd

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH v3 01/12] irqchip: armada-370-xp: add Kconfig option for the driver Gregory CLEMENT <gregory.clement@free-electrons.com> - 2016-02-08 18:20 +0100
  Re: [PATCH v3 01/12] irqchip: armada-370-xp: add Kconfig option for the driver Arnd Bergmann <arnd@arndb.de> - 2016-02-09 16:20 +0100

csiph-web