Re: [PATCH 1/3] KVM: APIC: remove unnecessary double checks on APIC existence

From	Radim Krčmář <rkrcmar@redhat.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH 1/3] KVM: APIC: remove unnecessary double checks on APIC existence
Date	2016-02-09 16:20 +0100
Message-ID	<r0if8-5Nd-23@gated-at.bofh.it> (permalink)
References	<qZWHD-7Fq-13@gated-at.bofh.it> <qZWHD-7Fq-11@gated-at.bofh.it> <r0gZI-4N6-5@gated-at.bofh.it> <r0i5r-5IR-1@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

2016-02-09 16:06+0100, Paolo Bonzini:
> On 09/02/2016 14:55, Radim Krčmář wrote:
>> This is most likely going to bug on the following path:
>>   handle_apic_access -> kvm_lapic_set_eoi
>> 
>> Before the change, handle_apic_access would just drop EOIs that should
>> have gone to user space ... I'm not sure if we tested it, or the path is
>> really never taken.
> 
> cpu_need_virtualize_apic_accesses is needed to set
> SECONDARY_EXEC_VIRTUALIZE_APIC_ACCESSES (vmx_secondary_exec_control) and
> SECONDARY_EXEC_VIRTUALIZE_APIC_ACCESSES is required to get to
> handle_apic_access.

Thanks,

Reviewed-by: Radim Krčmář <rkrcmar@redhat.com>

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH 1/3] KVM: APIC: remove unnecessary double checks on APIC existence Paolo Bonzini <pbonzini@redhat.com> - 2016-02-08 17:20 +0100
  Re: [PATCH 1/3] KVM: APIC: remove unnecessary double checks on APIC  existence Radim Krčmář <rkrcmar@redhat.com> - 2016-02-09 15:00 +0100
    Re: [PATCH 1/3] KVM: APIC: remove unnecessary double checks on APIC  existence Paolo Bonzini <pbonzini@redhat.com> - 2016-02-09 16:10 +0100
      Re: [PATCH 1/3] KVM: APIC: remove unnecessary double checks on APIC  existence Radim Krčmář <rkrcmar@redhat.com> - 2016-02-09 16:20 +0100

csiph-web