Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1330071

Re: Re: [PATCH v2 06/10] ARM64: dts: rockchip: Add IR receiver to GeekBox

From Julien Chauveau <chauveau.julien@gmail.com>
Newsgroups linux.kernel
Subject Re: Re: [PATCH v2 06/10] ARM64: dts: rockchip: Add IR receiver to GeekBox
Date 2016-02-09 11:50 +0100
Message-ID <r0e1S-2PZ-53@gated-at.bofh.it> (permalink)
References <qZJAK-6SN-3@gated-at.bofh.it> <qZJKq-6We-19@gated-at.bofh.it> <r06QG-6k0-9@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


Le 09/02/2016 04:08, Andreas Färber a écrit :
> Am 08.02.2016 um 03:17 schrieb Andreas Färber:
>> Signed-off-by: Andreas Färber <afaerber@suse.de>
>> ---
>>   v2: New
>>   
>>   arch/arm64/boot/dts/rockchip/rk3368-geekbox.dts | 13 +++++++++++++
>>   1 file changed, 13 insertions(+)
>>
>> diff --git a/arch/arm64/boot/dts/rockchip/rk3368-geekbox.dts b/arch/arm64/boot/dts/rockchip/rk3368-geekbox.dts
>> index e4523a74050f..e84383fd6f10 100644
>> --- a/arch/arm64/boot/dts/rockchip/rk3368-geekbox.dts
>> +++ b/arch/arm64/boot/dts/rockchip/rk3368-geekbox.dts
>> @@ -63,6 +63,13 @@
>>   		#clock-cells = <0>;
>>   	};
>>   
>> +	ir: ir-receiver {
>> +		compatible = "gpio-ir-receiver";
>> +		gpios = <&gpio3 30 GPIO_ACTIVE_LOW>;
>> +		pinctrl-names = "default";
>> +		pinctrl-0 = <&ir_int>;
> 		status = "disabled";
>
> Should only be enabled in the new Landingship config. Will fix.
>
> Andreas
Actually there's two IR receivers:
- one on the geekbox module (on the bottom side)
- and another one on the landingship.

Both are connected to the same GPIO pin, so you can keep it enabled in 
the main geekbox dts.

About the pinctrl, same remark as for gpio-keys: there's already 
external pull-up resistors on this pin, so it should be better to use 
pcfg_pull_none instead of pcfg_pull_up.

Julien
>
> P.S. See Heiko, two bugs in the new nodes already, glad I have them
> separate. :)
>
>> +	};
>> +
>>   	leds: gpio-leds {
>>   		compatible = "gpio-leds";
>>   
> [snip]
>

Back to linux.kernel | Previous | NextPrevious in thread | Next in thread | Find similar | Unroll thread


Thread

[PATCH v2 00/10] ARM64: rockchip: Initial GeekBox enablement Andreas Färber <afaerber@suse.de> - 2016-02-08 03:20 +0100
  [PATCH v2 08/10] ARM64: dts: rockchip: Add tsadc for GeekBox Andreas Färber <afaerber@suse.de> - 2016-02-08 03:20 +0100
  [PATCH v2 04/10] ARM64: dts: rockchip: Add GMAC to GeekBox Andreas Färber <afaerber@suse.de> - 2016-02-08 03:20 +0100
    Re: [PATCH v2 04/10] ARM64: dts: rockchip: Add GMAC to GeekBox Heiko Stuebner <heiko@sntech.de> - 2016-02-08 11:30 +0100
      Re: [PATCH v2 04/10] ARM64: dts: rockchip: Add GMAC to GeekBox Andreas Färber <afaerber@suse.de> - 2016-02-08 11:50 +0100
  [PATCH v2 09/10] Documentation: devicetree: rockchip: Document Landingship Andreas Färber <afaerber@suse.de> - 2016-02-08 03:20 +0100
    Re: [PATCH v2 09/10] Documentation: devicetree: rockchip: Document Landingship Heiko Stuebner <heiko@sntech.de> - 2016-02-08 11:30 +0100
      Re: [PATCH v2 09/10] Documentation: devicetree: rockchip: Document  Landingship Andreas Färber <afaerber@suse.de> - 2016-02-08 12:00 +0100
  [PATCH v2 10/10] ARM64: dts: rockchip: Add Landingship config Andreas Färber <afaerber@suse.de> - 2016-02-08 03:30 +0100
  [PATCH v2 07/10] ARM64: dts: rockchip: Add power key to GeekBox Andreas Färber <afaerber@suse.de> - 2016-02-08 03:30 +0100
    Re: [PATCH v2 07/10] ARM64: dts: rockchip: Add power key to GeekBox Julien Chauveau <chauveau.julien@gmail.com> - 2016-02-08 17:30 +0100
  [PATCH v2 06/10] ARM64: dts: rockchip: Add IR receiver to GeekBox Andreas Färber <afaerber@suse.de> - 2016-02-08 03:30 +0100
    Re: [PATCH v2 06/10] ARM64: dts: rockchip: Add IR receiver to GeekBox Andreas Färber <afaerber@suse.de> - 2016-02-09 04:10 +0100
      Re: Re: [PATCH v2 06/10] ARM64: dts: rockchip: Add IR receiver to  GeekBox Julien Chauveau <chauveau.julien@gmail.com> - 2016-02-09 11:50 +0100
  [PATCH v2 05/10] ARM64: dts: rockchip: Add eMMC to GeekBox Andreas Färber <afaerber@suse.de> - 2016-02-08 03:30 +0100

csiph-web