Re: [PATCH V4 2/7] cpufreq: Call __cpufreq_governor() with policy->rwsem held

From	Viresh Kumar <viresh.kumar@linaro.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH V4 2/7] cpufreq: Call __cpufreq_governor() with policy->rwsem held
Date	2016-02-11 13:00 +0100
Message-ID	<r0Y4H-8bX-21@gated-at.bofh.it> (permalink)
References	<r07tn-6FT-3@gated-at.bofh.it> <r07to-6FT-13@gated-at.bofh.it> <r0W2T-6Wl-15@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On 11-02-16, 10:48, Rafael J. Wysocki wrote:
> On Tue, Feb 9, 2016 at 4:46 AM, Viresh Kumar <viresh.kumar@linaro.org> wrote:
> > Also note that cpufreq_driver->stop_cpu() and ->exit() can get called
> > while policy->rwsem is held. That shouldn't have any side effects
> > though.
> 
> The last paragraph is unclear.
> 
> Is it supposed to mean that the change will cause
> cpufreq_driver->stop_cpu() and ->exit() to be called under
> policy->rwsem sometimes?

Yeah, reworded it a bit ..

Also note that, after this patch cpufreq_driver->stop_cpu() and ->exit()
will get called while policy->rwsem is held, which wasn't the case
earlier. That shouldn't have any side effects though.

-- 
viresh

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

Re: [PATCH V4 2/7] cpufreq: Call __cpufreq_governor() with  policy->rwsem held "Rafael J. Wysocki" <rafael@kernel.org> - 2016-02-11 10:50 +0100
  Re: [PATCH V4 2/7] cpufreq: Call __cpufreq_governor() with  policy->rwsem held Viresh Kumar <viresh.kumar@linaro.org> - 2016-02-11 13:00 +0100

csiph-web