Re: [PATCH] Optimize int_sqrt for small values for faster idle

Path	csiph.com!aioe.org!bofh.it!news.nic.it!robomod
From	Fengguang Wu <fengguang.wu@intel.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH] Optimize int_sqrt for small values for faster idle
Date	Wed, 10 Feb 2016 14:40:02 +0100
Message-ID	<r0D9U-2Ne-3@gated-at.bofh.it> (permalink)
References	<qW2BY-13z-9@gated-at.bofh.it> <qXucO-qs-11@gated-at.bofh.it> <qXumu-vl-13@gated-at.bofh.it> <qZFdM-3BZ-29@gated-at.bofh.it> <r0nov-QC-5@gated-at.bofh.it>
X-Extloop1	1
X-Ironport-Av	E=Sophos;i="5.22,426,1449561600"; d="scan'208";a="650080241"
MIME-Version	1.0
Content-Type	text/plain; charset=us-ascii
Content-Disposition	inline
User-Agent	Mutt/1.5.24 (2015-08-30)
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	39
Organization	linux.* mail to news gateway
X-Original-Cc	Rasmus Villemoes <linux@rasmusvillemoes.dk>, Andi Kleen <andi@firstfloor.org>, akpm@linux-foundation.org, linux-kernel@vger.kernel.org, rafael.j.wysocki@intel.com, lenb@kernel.org
X-Original-Date	Wed, 10 Feb 2016 21:31:05 +0800
X-Original-Message-ID	<20160210133105.GB22162@wfg-t540p.sh.intel.com>
X-Original-References	<1454017365-8509-1-git-send-email-andi@firstfloor.org> <87y4b4azsy.fsf@rasmusvillemoes.dk> <20160201213622.GA15302@tassilo.jf.intel.com> <874mdkfbpx.fsf@rasmusvillemoes.dk> <20160209204400.GC4875@tassilo.jf.intel.com>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	csiph.com linux.kernel:1331171

Show key headers only | View raw

On Tue, Feb 09, 2016 at 12:44:00PM -0800, Andi Kleen wrote:
> On Sun, Feb 07, 2016 at 10:32:26PM +0100, Rasmus Villemoes wrote:
> > On Mon, Feb 01 2016, Andi Kleen <ak@linux.intel.com> wrote:
> > 
> > > On Mon, Feb 01, 2016 at 10:25:17PM +0100, Rasmus Villemoes wrote:
> > >> On Thu, Jan 28 2016, Andi Kleen <andi@firstfloor.org> wrote:
> > >> 
> > >> > From: Andi Kleen <ak@linux.intel.com>
> > >> >
> > >> > The menu cpuidle governor does at least two int_sqrt() each time
> > >> > we go into idle in get_typical_interval to compute stddev
> > >> >
> > >> > int_sqrts take 100-120 cycles each. Short idle latency is important
> > >> > for many workloads.
> > >> >
> > >> 
> > >> If you want to optimize get_typical_interval(), why not just take the
> > >> square root out of the equation (literally)?
> > >> 
> > >> Something like
> > >
> > > Looks good. Yes that's a better fix.
> > >
> > 
> > Andi, did you have a way to measure the impact, and if so, could I get
> > you to run the numbers again with my patch?
> 
> I got the numbers from the 0day runs (AIM7 gets faster)
> In theory if you post the patch that should happen automatically
> (checking with Fengguang)

Yes we bisect and report a lot of runtime performance changes.
On the other hand, some few will be missed, too, due to various
unstableness issues. Anyway if you would like to study performance
impacts of a patch, feel free to send us requests to gather the
numbers and do comparison.

Thanks,
Fengguang

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

Re: [PATCH] Optimize int_sqrt for small values for faster idle Andi Kleen <ak@linux.intel.com> - 2016-02-09 21:50 +0100
  Re: [PATCH] Optimize int_sqrt for small values for faster idle Fengguang Wu <fengguang.wu@intel.com> - 2016-02-10 14:40 +0100

csiph-web