Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1329634

Re: [PATCH 0/4] powerpc/ps3: gelic_udbg: drop local versions of network data structs

Show all headers | View raw

On Mon, Feb 08, 2016 at 09:31:21AM +0100, Geert Uytterhoeven wrote:
> On Sun, Feb 7, 2016 at 6:38 PM, Luis Henriques
> <luis.henriques@canonical.com> wrote:
> > Several network-related data structures are defined in gelic_udbg.
> > These could be easily dropped and the standard ones defined in network
> > headers could be used instead.
> >
> > The 4 patches that follow replace ethernet, vlan, ip and udp
> > structures in gelic_udbg.  Note that this has been compile-tested
> > only.
> 
> A few of these were declared __packed in the gelic driver, while that
> attribute isn't used for the standard definitions.
> 
> It probably doesn't make a difference, as there are no gaps in the structures
> when unpacked, unless pointers to the structures themselves are unaligned.
>

Thank you for your comments, Geert.  I had noticed those differences,
but the quick code review I did didn't show any issues with that could
be triggered by this change.  But as I referred, I only compile-tested
this code and didn't actually executed it in the real hw.

Cheers,
--
Luís

> > Luis Henriques (4):
> >   powerpc/ps3: gelic_udbg: use struct ethhdr from <linux/if_ether.h>
> >   powerpc/ps3: gelic_udbg: use struct vlan_hdr from <linux/if_vlan.h>
> >   powerpc/ps3: gelic_udbg: use struct iphdr from <linux/ip.h>
> >   powerpc/ps3: gelic_udbg: use struct udphdr from <linux/udp.h>
> >
> >  arch/powerpc/platforms/ps3/gelic_udbg.c | 71 +++++++++++----------------------
> >  1 file changed, 23 insertions(+), 48 deletions(-)
> 
> Gr{oetje,eeting}s,
> 
>                         Geert
> 
> --
> Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
> 
> In personal conversations with technical people, I call myself a hacker. But
> when I'm talking to journalists I just say "programmer" or something like that.
>                                 -- Linus Torvalds

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH 0/4] powerpc/ps3: gelic_udbg: drop local versions of network data structs Luis Henriques <luis.henriques@canonical.com> - 2016-02-07 18:40 +0100
  [PATCH 4/4] powerpc/ps3: gelic_udbg: use struct udphdr from <linux/udp.h> Luis Henriques <luis.henriques@canonical.com> - 2016-02-07 18:40 +0100
  [PATCH 1/4] powerpc/ps3: gelic_udbg: use struct ethhdr from <linux/if_ether.h> Luis Henriques <luis.henriques@canonical.com> - 2016-02-07 18:50 +0100
    Re: [PATCH 1/4] powerpc/ps3: gelic_udbg: use struct ethhdr from  <linux/if_ether.h> Joe Perches <joe@perches.com> - 2016-02-07 20:40 +0100
      Re: [PATCH 1/4] powerpc/ps3: gelic_udbg: use struct ethhdr from  <linux/if_ether.h> Luis Henriques <luis.henriques@canonical.com> - 2016-02-08 23:10 +0100
  [PATCH 3/4] powerpc/ps3: gelic_udbg: use struct iphdr from <linux/ip.h> Luis Henriques <luis.henriques@canonical.com> - 2016-02-07 18:50 +0100
  [PATCH 2/4] powerpc/ps3: gelic_udbg: use struct vlan_hdr from <linux/if_vlan.h> Luis Henriques <luis.henriques@canonical.com> - 2016-02-07 18:50 +0100
  Re: [PATCH 0/4] powerpc/ps3: gelic_udbg: drop local versions of  network data structs Geert Uytterhoeven <geert@linux-m68k.org> - 2016-02-08 09:40 +0100
    Re: [PATCH 0/4] powerpc/ps3: gelic_udbg: drop local versions of  network data structs Luis Henriques <luis.henriques@canonical.com> - 2016-02-08 23:20 +0100

csiph-web