Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1328569

Re: [PATCH 1/4] powerpc/ps3: gelic_udbg: use struct ethhdr from <linux/if_ether.h>

Show all headers | View raw

On Sun, 2016-02-07 at 17:38 +0000, Luis Henriques wrote:
> Instead of defining a local version of struct ethhdr use the standard
> definition from .

trivia:

> diff --git a/arch/powerpc/platforms/ps3/gelic_udbg.c b/arch/powerpc/platforms/ps3/gelic_udbg.c
[]
> @@ -173,8 +169,8 @@ static void gelic_debug_init(void)
>  
>  	h_eth = (struct ethhdr *)dbg.pkt;
>  
> -	memset(&h_eth->dest, 0xff, 6);
> -	memcpy(&h_eth->src, &mac, 6);
> +	memset(&h_eth->h_dest, 0xff, 6);
> +	memcpy(&h_eth->h_source, &mac, 6);

Be nice to use ETH_ALEN and eth_broadcast_addr.
Maybe ether_addr_copy too.

> @@ -183,7 +179,7 @@ static void gelic_debug_init(void)
>  				 GELIC_LV1_VLAN_TX_ETHERNET_0, 0, 0,
>  				 &vlan_id, &v2);
>  	if (!result) {
> -		h_eth->type = 0x8100;
> +		h_eth->h_proto= 0x8100;

ETH_P_8021Q

>  		header_size += sizeof(struct vlantag);
>  		h_vlan = (struct vlantag *)(h_eth + 1);
> @@ -191,7 +187,7 @@ static void gelic_debug_init(void)
>  		h_vlan->subtype = 0x0800;
>  		h_ip = (struct iphdr *)(h_vlan + 1);
>  	} else {
> -		h_eth->type = 0x0800;
> +		h_eth->h_proto= 0x0800;

ETH_P_IP

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH 0/4] powerpc/ps3: gelic_udbg: drop local versions of network data structs Luis Henriques <luis.henriques@canonical.com> - 2016-02-07 18:40 +0100
  [PATCH 4/4] powerpc/ps3: gelic_udbg: use struct udphdr from <linux/udp.h> Luis Henriques <luis.henriques@canonical.com> - 2016-02-07 18:40 +0100
  [PATCH 1/4] powerpc/ps3: gelic_udbg: use struct ethhdr from <linux/if_ether.h> Luis Henriques <luis.henriques@canonical.com> - 2016-02-07 18:50 +0100
    Re: [PATCH 1/4] powerpc/ps3: gelic_udbg: use struct ethhdr from  <linux/if_ether.h> Joe Perches <joe@perches.com> - 2016-02-07 20:40 +0100
      Re: [PATCH 1/4] powerpc/ps3: gelic_udbg: use struct ethhdr from  <linux/if_ether.h> Luis Henriques <luis.henriques@canonical.com> - 2016-02-08 23:10 +0100
  [PATCH 3/4] powerpc/ps3: gelic_udbg: use struct iphdr from <linux/ip.h> Luis Henriques <luis.henriques@canonical.com> - 2016-02-07 18:50 +0100
  [PATCH 2/4] powerpc/ps3: gelic_udbg: use struct vlan_hdr from <linux/if_vlan.h> Luis Henriques <luis.henriques@canonical.com> - 2016-02-07 18:50 +0100
  Re: [PATCH 0/4] powerpc/ps3: gelic_udbg: drop local versions of  network data structs Geert Uytterhoeven <geert@linux-m68k.org> - 2016-02-08 09:40 +0100
    Re: [PATCH 0/4] powerpc/ps3: gelic_udbg: drop local versions of  network data structs Luis Henriques <luis.henriques@canonical.com> - 2016-02-08 23:20 +0100

csiph-web