Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1329655

Re: [PATCH 1/9] rfkill: Improve documentation language

Path csiph.com!feeder.erje.net!2.us.feeder.erje.net!newsfeed.fsmpi.rwth-aachen.de!newsfeed.straub-nv.de!news.mixmin.net!aioe.org!gothmog.csi.it!bofh.it!news.nic.it!robomod
From Julian Calaby <julian.calaby@gmail.com>
Newsgroups linux.kernel
Subject Re: [PATCH 1/9] rfkill: Improve documentation language
Date Mon, 08 Feb 2016 23:40:02 +0100
Message-ID <r02Do-36m-25@gated-at.bofh.it> (permalink)
References <qZWeB-7eV-5@gated-at.bofh.it> <qZWeC-7eV-39@gated-at.bofh.it>
Dkim-Signature v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc:content-type:content-transfer-encoding; bh=iMvHdjvAZ/yTPY6o2xJV9JAENqGeUFMbsNkCrEZSwFU=; b=P32hvwVUElNjuu/kQ4rmCsdd30r6FHTxNX0jmgOrZlRzgqpPKn1kFS7C/na6x7HsEg uzjzcMRw+HbKuMLkb3nkqZDfILYdq5uknyfT3Zihl5eueBgtLBxx7z4NyWXfFbmRNPQ5 jINyuczLWegQqxra+cqJjC2FSg2+Q2Putvofh8E8yaZhx/kMHei53J52fBhIVhK6lrsS pGLdF1pqdZl5kuQhAqOUHhlJKz2WKX2zOUDAZRN3v2q0IgcrBn/tgHsT5NIf9Ebbg2ad OaAa6SLxB/J5CSgKXyzQubgfYSJSG2tmLMl/MxDIZO+IpqOrIG93EKYdQ4bhAMmnZG1z sqIw==
X-Google-Dkim-Signature v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc:content-type:content-transfer-encoding; bh=iMvHdjvAZ/yTPY6o2xJV9JAENqGeUFMbsNkCrEZSwFU=; b=SPY1wCza8SmoSJQZ3DsO2DlSew5WDpmwy+w7Ao+iK6c5ojrZDZRXzahRHCdNybKTM5 sHpZQI0k6ytdN77Jk7nYeiqrqs43MJu+xgUr3Us0nlIPaROHXW0gsyvvRQUjOTPPkRpT oBcuI5ipnMEbcNpcusxl2Ce9GjOAOtvfo48xHyYcahYVou20hMcqz1seMHvzSfok3VBx EPj25SABgqtzXf04hBZUPx+wc6vdwnuuMqeTpkkvDD+8cHWPRR9D6suaSSMal0Ny21Eb 3YZbEnZowKq/qqRI4ePb4A5EE2eSIUBY1QE3w314bOPoXDgon4/B5qfKQgo0cePmi4gs HYvA==
X-Gm-Message-State AG10YOQdJbTI22NKTCdN+bWyuoHYzS55kE7am+rYuBEPwAgJp3pYqzKimzuWLHXh7gvLxk+YAwRjLJeST/iNgg==
X-Received by 10.107.159.7 with SMTP id i7mr28110921ioe.29.1454971071999; Mon, 08 Feb 2016 14:37:51 -0800 (PST)
MIME-Version 1.0
Content-Type text/plain; charset=UTF-8
Content-Transfer-Encoding 8BIT
Sender robomod@news.nic.it
List-ID <linux-kernel.vger.kernel.org>
X-Mailing-List linux-kernel@vger.kernel.org
Approved robomod@news.nic.it
Lines 43
Organization linux.* mail to news gateway
X-Original-Cc Johannes Berg <johannes@sipsolutions.net>, "David S. Miller" <davem@davemloft.net>, Darren Hart <dvhart@infradead.org>, linux-wireless <linux-wireless@vger.kernel.org>, netdev <netdev@vger.kernel.org>, platform-driver-x86@vger.kernel.org, linux-api@vger.kernel.org, linux-doc@vger.kernel.org, "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>, linux@endlessm.com, João Paulo Rechi Vita <jprvita@endlessm.com>
X-Original-Date Tue, 9 Feb 2016 09:37:32 +1100
X-Original-Message-ID <CAGRGNgX7ANq_dTSkRCqnU2H5DQsLCf5Ni7M-n7Z_RSieOf=mOw@mail.gmail.com>
X-Original-References <1454946096-9752-1-git-send-email-jprvita@endlessm.com> <1454946096-9752-2-git-send-email-jprvita@endlessm.com>
X-Original-Sender linux-kernel-owner@vger.kernel.org
Xref csiph.com linux.kernel:1329655

Show key headers only | View raw


Hi João,

On Tue, Feb 9, 2016 at 2:41 AM, João Paulo Rechi Vita <jprvita@gmail.com> wrote:
> Signed-off-by: João Paulo Rechi Vita <jprvita@endlessm.com>

Looks right to me.

Reviewed-by: Julian Calaby <julian.calaby@gmail.com>

> ---
>  net/rfkill/core.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/net/rfkill/core.c b/net/rfkill/core.c
> index a805831..ffbc375 100644
> --- a/net/rfkill/core.c
> +++ b/net/rfkill/core.c
> @@ -282,8 +282,8 @@ static void rfkill_set_block(struct rfkill *rfkill, bool blocked)
>         spin_lock_irqsave(&rfkill->lock, flags);
>         if (err) {
>                 /*
> -                * Failed -- reset status to _prev, this may be different
> -                * from what set set _PREV to earlier in this function
> +                * Failed -- reset status to _PREV, which may be different
> +                * from what we have set _PREV to earlier in this function
>                  * if rfkill_set_sw_state was invoked.
>                  */
>                 if (rfkill->state & RFKILL_BLOCK_SW_PREV)
> --
> 2.5.0
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html



-- 
Julian Calaby

Email: julian.calaby@gmail.com
Profile: http://www.google.com/profiles/julian.calaby/

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread


Thread

[PATCH 1/9] rfkill: Improve documentation language "João Paulo Rechi Vita" <jprvita@gmail.com> - 2016-02-08 16:50 +0100
  Re: [PATCH 1/9] rfkill: Improve documentation language Julian Calaby <julian.calaby@gmail.com> - 2016-02-08 23:40 +0100

csiph-web