Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1329598

Re: [PATCH] net: fec: Add "phy-reset-active-low" property to DT

Show all headers | View raw

On Mon, Feb 08, 2016 at 09:21:13PM +0100, Bernhard Walle wrote:
> We need that for a custom hardware that needs the reverse reset
> sequence.
> 
> Signed-off-by: Bernhard Walle <bernhard@bwalle.de>
> ---
>  Documentation/devicetree/bindings/net/fsl-fec.txt | 3 +++
>  drivers/net/ethernet/freescale/fec_main.c         | 8 ++++++--
>  2 files changed, 9 insertions(+), 2 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/net/fsl-fec.txt b/Documentation/devicetree/bindings/net/fsl-fec.txt
> index a9eb611..a4799ff 100644
> --- a/Documentation/devicetree/bindings/net/fsl-fec.txt
> +++ b/Documentation/devicetree/bindings/net/fsl-fec.txt
> @@ -12,6 +12,9 @@ Optional properties:
>    only if property "phy-reset-gpios" is available.  Missing the property
>    will have the duration be 1 millisecond.  Numbers greater than 1000 are
>    invalid and 1 millisecond will be used instead.
> +- phy-reset-active-low : If present then the reset sequence using the GPIO
> +  specified in the "phy-reset-gpios" property is reversed (H=reset state,
> +  L=operation state).

Hi Bernhard

Maybe at the same time add a comment to phy-reset-gpios that the flags
part is ignored, see the none standard phy-reset-active-low property
instead.

	Andrew

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH] net: fec: Add "phy-reset-active-low" property to DT Bernhard Walle <bernhard@bwalle.de> - 2016-02-08 21:30 +0100
  Re: [PATCH] net: fec: Add "phy-reset-active-low" property to DT Andrew Lunn <andrew@lunn.ch> - 2016-02-08 22:50 +0100
  Re: [PATCH] net: fec: Add "phy-reset-active-low" property to DT Arnd Bergmann <arnd@arndb.de> - 2016-02-08 22:50 +0100
    Re: [PATCH] net: fec: Add "phy-reset-active-low" property to DT Andrew Lunn <andrew@lunn.ch> - 2016-02-08 23:00 +0100
      Re: [PATCH] net: fec: Add "phy-reset-active-low" property to DT Arnd Bergmann <arnd@arndb.de> - 2016-02-09 15:50 +0100
  Re: [PATCH] net: fec: Add "phy-reset-active-low" property to DT David Miller <davem@davemloft.net> - 2016-02-16 21:20 +0100

csiph-web