Re: [PATCH] mtd: denali: fix property name for Denali DT binding

From	Rob Herring <robh@kernel.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH] mtd: denali: fix property name for Denali DT binding
Date	2016-02-08 22:40 +0100
Message-ID	<r01Hm-2vO-43@gated-at.bofh.it> (permalink)
References	<qZOAq-22G-9@gated-at.bofh.it> <qZPwu-2Hf-9@gated-at.bofh.it> <qZPGa-2M0-3@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Mon, Feb 08, 2016 at 05:41:33PM +0900, Masahiro Yamada wrote:
> Hi Arnd,
> 
> 
> 2016-02-08 17:29 GMT+09:00 Arnd Bergmann <arnd@arndb.de>:
> > On Monday 08 February 2016 16:31:42 Masahiro Yamada wrote:
> >> diff --git a/Documentation/devicetree/bindings/mtd/denali-nand.txt b/Documentation/devicetree/bindings/mtd/denali-nand.txt
> >> index b04d03a..785b825 100644
> >> --- a/Documentation/devicetree/bindings/mtd/denali-nand.txt
> >> +++ b/Documentation/devicetree/bindings/mtd/denali-nand.txt
> >> @@ -5,7 +5,7 @@ Required properties:
> >>    - reg : should contain registers location and length for data and reg.
> >>    - reg-names: Should contain the reg names "nand_data" and "denali_reg"
> >>    - interrupts : The interrupt number.
> >> -  - dm-mask : DMA bit mask
> >> +  - dma-mask : DMA bit mask
> >>
> >>  The device tree may optionally contain sub-nodes describing partitions of the
> >>  address space. See partition.txt for more detail.
> >>
> >
> > It looks like this binding is wrong in multiple ways, and it doesn't seem to
> > be used in any .dts files. Is this actually being shipped anywhere or
> > could we try to fix the binding properly?
> >
> 
> Looks like it is locally used in Altera's Rocketboard tree now.
> 
> See this:
> 
> https://github.com/altera-opensource/linux-socfpga/blob/socfpga-4.3/arch/arm/boot/dts/socfpga.dtsi
> 
> 
> I hope Dinh can comment on the status.

From the looks of it, this property should be dropped and the driver 
should be updated to not touch dev->dma_mask. The core sets it up 
correctly now.

Rob

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] mtd: denali: fix property name for Denali DT binding Masahiro Yamada <yamada.masahiro@socionext.com> - 2016-02-08 08:40 +0100
  Re: [PATCH] mtd: denali: fix property name for Denali DT binding Arnd Bergmann <arnd@arndb.de> - 2016-02-08 09:40 +0100
    Re: [PATCH] mtd: denali: fix property name for Denali DT binding Masahiro Yamada <yamada.masahiro@socionext.com> - 2016-02-08 09:50 +0100
      Re: [PATCH] mtd: denali: fix property name for Denali DT binding Rob Herring <robh@kernel.org> - 2016-02-08 22:40 +0100

csiph-web