Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1279182
| From | Andrew Lunn <andrew@lunn.ch> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH 2/4] ARM: dt: mvebu: ix4-300d: move partitions to partition sub-node |
| Date | 2015-11-28 18:10 +0100 |
| Message-ID | <qzRax-3by-15@gated-at.bofh.it> (permalink) |
| References | <qzLHQ-8cc-1@gated-at.bofh.it> <qzLHQ-8cc-15@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On Sat, Nov 28, 2015 at 12:14:06PM +0100, Sebastian Hesselbarth wrote:
> NAND flash partitions should be part of a partitions sub-node
> not the flash node itself. Move the partitions which will also
> allow different bootloaders get rid of the stock partitions
> easily by removing the partitions node.
>
> Signed-off-by: Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com>
Humm, did not know that. Quoting Documentation/devicetree/bindings/mtd/partition.txt:
The partition table should be a subnode of the mtd node and
should be named 'partitions'. Partitions are defined in subnodes
of the partitions node.
For backwards compatibility partitions as direct subnodes of the
mtd device are supported. This use is discouraged.
It also looks like none of the other MVEBU maintainers know that
either, since a quick look at the .dts files shows very few have a
partitions node.
Acked-by: Andrew Lunn <andrew@lunn.ch>
Thanks
Andrew
> ---
> Cc: Jason Cooper <jason@lakedaemon.net>
> Cc: Andrew Lunn <andrew@lunn.ch>
> Cc: Gregory Clement <gregory.clement@free-electrons.com>
> Cc: Rob Herring <robh+dt@kernel.org>
> Cc: Pawel Moll <pawel.moll@arm.com>
> Cc: Mark Rutland <mark.rutland@arm.com>
> Cc: Ian Campbell <ijc+devicetree@hellion.org.uk>
> Cc: Kumar Gala <galak@codeaurora.org>
> Cc: Russell King <linux@arm.linux.org.uk>
> Cc: Benoit Masson <yahoo@perenite.com>
> Cc: linux-arm-kernel@lists.infradead.org
> Cc: devicetree@vger.kernel.org
> Cc: linux-kernel@vger.kernel.org
> ---
> arch/arm/boot/dts/armada-xp-lenovo-ix4-300d.dts | 67 +++++++++++++------------
> 1 file changed, 36 insertions(+), 31 deletions(-)
>
> diff --git a/arch/arm/boot/dts/armada-xp-lenovo-ix4-300d.dts b/arch/arm/boot/dts/armada-xp-lenovo-ix4-300d.dts
> index 30a0a6eac645..76781fd18624 100644
> --- a/arch/arm/boot/dts/armada-xp-lenovo-ix4-300d.dts
> +++ b/arch/arm/boot/dts/armada-xp-lenovo-ix4-300d.dts
> @@ -151,37 +151,42 @@
> marvell,nand-enable-arbiter;
> nand-on-flash-bbt;
>
> - partition@0 {
> - label = "u-boot";
> - reg = <0x0000000 0xe0000>;
> - read-only;
> - };
> -
> - partition@e0000 {
> - label = "u-boot-env";
> - reg = <0xe0000 0x20000>;
> - read-only;
> - };
> -
> - partition@100000 {
> - label = "u-boot-env2";
> - reg = <0x100000 0x20000>;
> - read-only;
> - };
> -
> - partition@120000 {
> - label = "zImage";
> - reg = <0x120000 0x400000>;
> - };
> -
> - partition@520000 {
> - label = "initrd";
> - reg = <0x520000 0x400000>;
> - };
> -
> - partition@xE00000 {
> - label = "boot";
> - reg = <0xE00000 0x3F200000>;
> + partitions {
> + #address-cells = <1>;
> + #size-cells = <1>;
> +
> + partition@0 {
> + label = "u-boot";
> + reg = <0x0000000 0xe0000>;
> + read-only;
> + };
> +
> + partition@e0000 {
> + label = "u-boot-env";
> + reg = <0xe0000 0x20000>;
> + read-only;
> + };
> +
> + partition@100000 {
> + label = "u-boot-env2";
> + reg = <0x100000 0x20000>;
> + read-only;
> + };
> +
> + partition@120000 {
> + label = "zImage";
> + reg = <0x120000 0x400000>;
> + };
> +
> + partition@520000 {
> + label = "initrd";
> + reg = <0x520000 0x400000>;
> + };
> +
> + partition@xE00000 {
> + label = "boot";
> + reg = <0xE00000 0x3F200000>;
> + };
> };
> };
> };
> --
> 2.1.4
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH 0/4] ARM: dt: mvebu: ix4-300d: NAND cleanup and ECC Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com> - 2015-11-28 12:20 +0100
[PATCH 4/4] ARM: dt: mvebu: ix4-300d: Add ECC properties to NAND flash Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com> - 2015-11-28 12:20 +0100
Re: [PATCH 4/4] ARM: dt: mvebu: ix4-300d: Add ECC properties to NAND flash Andrew Lunn <andrew@lunn.ch> - 2015-11-28 18:10 +0100
Re: [PATCH 4/4] ARM: dt: mvebu: ix4-300d: Add ECC properties to NAND flash Thomas Petazzoni <thomas.petazzoni@free-electrons.com> - 2015-11-29 15:40 +0100
Re: [PATCH 4/4] ARM: dt: mvebu: ix4-300d: Add ECC properties to NAND flash Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com> - 2015-11-30 09:40 +0100
Re: [PATCH 4/4] ARM: dt: mvebu: ix4-300d: Add ECC properties to NAND flash Gregory CLEMENT <gregory.clement@free-electrons.com> - 2015-11-30 15:30 +0100
[PATCH 3/4] ARM: dt: mvebu: ix4-300d: Cleanup NAND partition ranges Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com> - 2015-11-28 12:20 +0100
Re: [PATCH 3/4] ARM: dt: mvebu: ix4-300d: Cleanup NAND partition ranges Andrew Lunn <andrew@lunn.ch> - 2015-11-28 18:10 +0100
Re: [PATCH 3/4] ARM: dt: mvebu: ix4-300d: Cleanup NAND partition ranges Gregory CLEMENT <gregory.clement@free-electrons.com> - 2015-11-30 15:30 +0100
[PATCH 1/4] ARM: dt: mvebu: ix4-300d: remove whole flash partition Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com> - 2015-11-28 12:20 +0100
Re: [PATCH 1/4] ARM: dt: mvebu: ix4-300d: remove whole flash partition Andrew Lunn <andrew@lunn.ch> - 2015-11-28 18:00 +0100
Re: [PATCH 1/4] ARM: dt: mvebu: ix4-300d: remove whole flash partition Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com> - 2015-11-28 18:40 +0100
Re: [PATCH 1/4] ARM: dt: mvebu: ix4-300d: remove whole flash partition Benoit Masson <benoitm@perenite.com> - 2015-11-28 21:40 +0100
Re: [PATCH 1/4] ARM: dt: mvebu: ix4-300d: remove whole flash partition Andrew Lunn <andrew@lunn.ch> - 2015-11-28 22:20 +0100
Re: [PATCH 1/4] ARM: dt: mvebu: ix4-300d: remove whole flash partition Gregory CLEMENT <gregory.clement@free-electrons.com> - 2015-11-30 15:20 +0100
[PATCH 2/4] ARM: dt: mvebu: ix4-300d: move partitions to partition sub-node Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com> - 2015-11-28 12:20 +0100
Re: [PATCH 2/4] ARM: dt: mvebu: ix4-300d: move partitions to partition sub-node Andrew Lunn <andrew@lunn.ch> - 2015-11-28 18:10 +0100
Re: [PATCH 2/4] ARM: dt: mvebu: ix4-300d: move partitions to partition sub-node Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com> - 2015-11-28 18:40 +0100
Re: [PATCH 2/4] ARM: dt: mvebu: ix4-300d: move partitions to partition sub-node Gregory CLEMENT <gregory.clement@free-electrons.com> - 2015-11-30 15:20 +0100
csiph-web