Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1276922

Re: [PATCH 00/04] pinctrl: sh-pfc: r8a7794: DU support

Show all headers | View raw

On Fri, Nov 20, 2015 at 04:46:50AM +0200, Laurent Pinchart wrote:
> Hi Magnus,
> 
> Thank you for the patch.
> 
> On Tuesday 17 November 2015 12:18:32 Magnus Damm wrote:
> > pinctrl: sh-pfc: r8a7794: DU support
> > 
> > [PATCH 01/04] pinctrl: sh-pfc: r8a7794: Add DU pin groups
> > [PATCH 02/04] pinctrl: sh-pfc: r8a7794: Separate DU CDE and DISP
> > [PATCH 03/04] pinctrl: sh-pfc: r8a7794: Add missing dot clock signals
> > [PATCH 04/04] pinctrl: sh-pfc: r8a7794: Break out ODDF from sync
> > 
> > These patches take the r8a7794 PFC DU support code from the BSP
> > and reworks it to fit the r8a7794 ALT board. Tested with the ALT
> > VGA port - by default PFC is not used however enabling PFC using
> > an incremental (yet to be posted) patch works well.
> > 
> > It is worth noting that patch 2-4 modifies the pin groups. This
> > means that the upstream DT ABI for PFC DU will differ compared
> > to the unreviewed BSP code.
> > 
> > In general it is not considered good practice to change the pin
> > groups and break compatibility since they are part of the DT ABI.
> > 
> > For this particular case upstream never have had PFC DU support
> > for r8a7794, so treating the BSP bindings as experimental and
> > migrate away seems reasonable.
> 
> If we start considering DT bindings that never went upstream as stable
> we'll have a big problem. I mean even bigger than the upstream DT
> bindings stability problem :-)

FWIW, I agree.

> > Signed-off-by: Magnus Damm <damm+renesas@opensource.se>
> 
> Wouldn't it make sense to merge the 4 patches together ?
> 
> > ---
> > 
> >  Written against v4.4-rc1
> > 
> >  drivers/pinctrl/sh-pfc/pfc-r8a7794.c |  282 +++++++++++++++++++++++++++----
> >  1 file changed, 252 insertions(+), 30 deletions(-)
> 
> -- 
> Regards,
> 
> Laurent Pinchart
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH 00/04] pinctrl: sh-pfc: r8a7794: DU support Magnus Damm <magnus.damm@gmail.com> - 2015-11-17 04:20 +0100
  [PATCH 01/04] pinctrl: sh-pfc: r8a7794: Add DU pin groups Magnus Damm <magnus.damm@gmail.com> - 2015-11-17 04:20 +0100
    Re: [PATCH 01/04] pinctrl: sh-pfc: r8a7794: Add DU pin groups Linus Walleij <linus.walleij@linaro.org> - 2015-11-29 22:30 +0100
      Re: [PATCH 01/04] pinctrl: sh-pfc: r8a7794: Add DU pin groups Geert Uytterhoeven <geert@linux-m68k.org> - 2015-11-30 10:00 +0100
  [PATCH 03/04] pinctrl: sh-pfc: r8a7794: Add missing dot clock signals Magnus Damm <magnus.damm@gmail.com> - 2015-11-17 04:20 +0100
  [PATCH 02/04] pinctrl: sh-pfc: r8a7794: Separate DU CDE and DISP Magnus Damm <magnus.damm@gmail.com> - 2015-11-17 04:20 +0100
  Re: [PATCH 00/04] pinctrl: sh-pfc: r8a7794: DU support Laurent Pinchart <laurent.pinchart@ideasonboard.com> - 2015-11-20 03:50 +0100
    Re: [PATCH 00/04] pinctrl: sh-pfc: r8a7794: DU support Magnus Damm <magnus.damm@gmail.com> - 2015-11-20 08:20 +0100
      Re: [PATCH 00/04] pinctrl: sh-pfc: r8a7794: DU support Laurent Pinchart <laurent.pinchart@ideasonboard.com> - 2015-11-20 16:00 +0100
    Re: [PATCH 00/04] pinctrl: sh-pfc: r8a7794: DU support Simon Horman <horms@verge.net.au> - 2015-11-25 01:20 +0100

csiph-web