Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1276822

Re: [Resend PATCH] RDS: fix race condition when sending a message on unbound socket

Show all headers | View raw

From: Santosh Shilimkar <santosh.shilimkar@oracle.com>
Date: Tue, 24 Nov 2015 17:13:21 -0500

> From: Quentin Casasnovas <quentin.casasnovas@oracle.com>
> 
> Sasha's found a NULL pointer dereference in the RDS connection code when
> sending a message to an apparently unbound socket.  The problem is caused
> by the code checking if the socket is bound in rds_sendmsg(), which checks
> the rs_bound_addr field without taking a lock on the socket.  This opens a
> race where rs_bound_addr is temporarily set but where the transport is not
> in rds_bind(), leading to a NULL pointer dereference when trying to
> dereference 'trans' in __rds_conn_create().
> 
> Vegard wrote a reproducer for this issue, so kindly ask him to share if
> you're interested.
> 
> I cannot reproduce the NULL pointer dereference using Vegard's reproducer
> with this patch, whereas I could without.
> 
> Complete earlier incomplete fix to CVE-2015-6937:
> 
>   74e98eb08588 ("RDS: verify the underlying transport exists before creating a connection")
> 
> Cc: David S. Miller <davem@davemloft.net>
> Cc: stable@vger.kernel.org
> 
> Reviewed-by: Vegard Nossum <vegard.nossum@oracle.com>
> Reviewed-by: Sasha Levin <sasha.levin@oracle.com>
> Acked-by: Santosh Shilimkar <santosh.shilimkar@oracle.com>
> Signed-off-by: Quentin Casasnovas <quentin.casasnovas@oracle.com>

Applied and queued up for -stable, thanks.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[Resend PATCH] RDS: fix race condition when sending a message on unbound socket Santosh Shilimkar <santosh.shilimkar@oracle.com> - 2015-11-24 20:20 +0100
  Re: [Resend PATCH] RDS: fix race condition when sending a message  on unbound socket David Miller <davem@redhat.com> - 2015-11-24 23:30 +0100
  RE: [Resend PATCH] RDS: fix race condition when sending a message  on unbound socket David Laight <David.Laight@ACULAB.COM> - 2015-11-25 13:30 +0100
    Re: [Resend PATCH] RDS: fix race condition when sending a message on  unbound socket Quentin Casasnovas <quentin.casasnovas@oracle.com> - 2015-11-25 14:00 +0100
      Re: [Resend PATCH] RDS: fix race condition when sending a message on  unbound socket santosh shilimkar <santosh.shilimkar@oracle.com> - 2015-11-26 01:00 +0100

csiph-web