Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1277331

RE: [Resend PATCH] RDS: fix race condition when sending a message on unbound socket

Show all headers | View raw

From: Santosh Shilimkar
> Sent: 24 November 2015 22:13
...
> Sasha's found a NULL pointer dereference in the RDS connection code when
> sending a message to an apparently unbound socket.  The problem is caused
> by the code checking if the socket is bound in rds_sendmsg(), which checks
> the rs_bound_addr field without taking a lock on the socket.  This opens a
> race where rs_bound_addr is temporarily set but where the transport is not
> in rds_bind(), leading to a NULL pointer dereference when trying to
> dereference 'trans' in __rds_conn_create().
> 
> Vegard wrote a reproducer for this issue, so kindly ask him to share if
> you're interested.
...
> diff --git a/net/rds/send.c b/net/rds/send.c
> index 827155c..c9cdb35 100644
> --- a/net/rds/send.c
> +++ b/net/rds/send.c
> @@ -1013,11 +1013,13 @@ int rds_sendmsg(struct socket *sock, struct msghdr *msg, size_t payload_len)
>  		release_sock(sk);

This is falling though into an unconditional lock_sock().
No need to unlock and relock immediately.

>  	}
> 
> -	/* racing with another thread binding seems ok here */
> +	lock_sock(sk);
>  	if (daddr == 0 || rs->rs_bound_addr == 0) {
> +		release_sock(sk);
>  		ret = -ENOTCONN; /* XXX not a great errno */
>  		goto out;
>  	}
> +	release_sock(sk);
> 

On the face of it the above looks somewhat dubious.
Locks usually tie together two action (eg a test and use of a value),
In this case you only have a test inside the lock.
That either means that the state can change after you release the lock
(ie rs->rs_bound_addr = 0 is executed somewhere), or you don't
really need the lock.

	David


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[Resend PATCH] RDS: fix race condition when sending a message on unbound socket Santosh Shilimkar <santosh.shilimkar@oracle.com> - 2015-11-24 20:20 +0100
  Re: [Resend PATCH] RDS: fix race condition when sending a message  on unbound socket David Miller <davem@redhat.com> - 2015-11-24 23:30 +0100
  RE: [Resend PATCH] RDS: fix race condition when sending a message  on unbound socket David Laight <David.Laight@ACULAB.COM> - 2015-11-25 13:30 +0100
    Re: [Resend PATCH] RDS: fix race condition when sending a message on  unbound socket Quentin Casasnovas <quentin.casasnovas@oracle.com> - 2015-11-25 14:00 +0100
      Re: [Resend PATCH] RDS: fix race condition when sending a message on  unbound socket santosh shilimkar <santosh.shilimkar@oracle.com> - 2015-11-26 01:00 +0100

csiph-web