Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1276732

Re: [PATCH v1 11/13] mfd: intel-lpss: Pass HSUART configuration via properties

Show all headers | View raw

On Tuesday 24 November 2015 12:22:57 Andy Shevchenko wrote:
> +static struct property_entry uart_properties[] = {
> +       PROPERTY_ENTRY_U32("reg-io-width", 4),
> +       PROPERTY_ENTRY_U32("reg-shift", 2),
> +       PROPERTY_ENTRY_U8("snps,uart-16550-compatible", 1),
> +       { },
> 

If I read the binding correctly, the "snps,uart-16550-compatible" property
is meant to be boolean, meaning true if present and zero-length or false
if absent. Using a u8 propert instead feels wrong.

Maybe we can have a PROPERTY_ENTRY_BOOL() for that?

	Arnd
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH v1 11/13] mfd: intel-lpss: Pass HSUART configuration via properties Andy Shevchenko <andriy.shevchenko@linux.intel.com> - 2015-11-24 11:30 +0100
  Re: [PATCH v1 11/13] mfd: intel-lpss: Pass HSUART configuration via  properties kbuild test robot <lkp@intel.com> - 2015-11-24 11:50 +0100
    Re: [PATCH v1 11/13] mfd: intel-lpss: Pass HSUART configuration via  properties Mika Westerberg <mika.westerberg@linux.intel.com> - 2015-11-24 12:20 +0100
  Re: [PATCH v1 11/13] mfd: intel-lpss: Pass HSUART configuration via properties Arnd Bergmann <arnd@arndb.de> - 2015-11-24 21:00 +0100
    Re: [PATCH v1 11/13] mfd: intel-lpss: Pass HSUART configuration via  properties Mika Westerberg <mika.westerberg@linux.intel.com> - 2015-11-25 13:20 +0100

csiph-web