Re: [PATCH v1 11/13] mfd: intel-lpss: Pass HSUART configuration via properties

From	Mika Westerberg <mika.westerberg@linux.intel.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH v1 11/13] mfd: intel-lpss: Pass HSUART configuration via properties
Date	2015-11-25 13:20 +0100
Message-ID	<qyHdf-6aD-7@gated-at.bofh.it> (permalink)
References	<qyj1f-6Rp-3@gated-at.bofh.it> <qyj1h-6Rp-51@gated-at.bofh.it> <qyrUS-43K-13@gated-at.bofh.it>
Organization	Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo

Show all headers | View raw

On Tue, Nov 24, 2015 at 08:53:04PM +0100, Arnd Bergmann wrote:
> On Tuesday 24 November 2015 12:22:57 Andy Shevchenko wrote:
> > +static struct property_entry uart_properties[] = {
> > +       PROPERTY_ENTRY_U32("reg-io-width", 4),
> > +       PROPERTY_ENTRY_U32("reg-shift", 2),
> > +       PROPERTY_ENTRY_U8("snps,uart-16550-compatible", 1),
> > +       { },
> > 
> 
> If I read the binding correctly, the "snps,uart-16550-compatible" property
> is meant to be boolean, meaning true if present and zero-length or false
> if absent. Using a u8 propert instead feels wrong.
> 
> Maybe we can have a PROPERTY_ENTRY_BOOL() for that?

That's a good idea. We'll add it to the next revision of the series.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH v1 11/13] mfd: intel-lpss: Pass HSUART configuration via properties Andy Shevchenko <andriy.shevchenko@linux.intel.com> - 2015-11-24 11:30 +0100
  Re: [PATCH v1 11/13] mfd: intel-lpss: Pass HSUART configuration via  properties kbuild test robot <lkp@intel.com> - 2015-11-24 11:50 +0100
    Re: [PATCH v1 11/13] mfd: intel-lpss: Pass HSUART configuration via  properties Mika Westerberg <mika.westerberg@linux.intel.com> - 2015-11-24 12:20 +0100
  Re: [PATCH v1 11/13] mfd: intel-lpss: Pass HSUART configuration via properties Arnd Bergmann <arnd@arndb.de> - 2015-11-24 21:00 +0100
    Re: [PATCH v1 11/13] mfd: intel-lpss: Pass HSUART configuration via  properties Mika Westerberg <mika.westerberg@linux.intel.com> - 2015-11-25 13:20 +0100

csiph-web