Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1276713

Re: [PATCH] reset: ath79: Add system restart support

Show all headers | View raw

On Tue, 24 Nov 2015 13:01:46 +0100
Philipp Zabel <p.zabel@pengutronix.de> wrote:

> Hi Alban,
> 
> Am Dienstag, den 24.11.2015, 01:00 +0100 schrieb Alban Bedel:
> > Add a system restart handler that use the FULL_CHIP_RESET bit of the
> > reset controller.
> > 
> > Signed-off-by: Alban Bedel <albeu@free.fr>
> 
> Applied, thanks.

Thanks to you :)

> Btw, should this driver #include <linux/io.h> for readl/writel?

Good question :) It turns out to be a MIPS glitch, asm/io.h is included
by asm/page.h which here come from linux/module.h. But we shouldn't
rely on this glitch and the driver should #include <linux/io.h>.
I'll fix this and add support for CONFIG_COMPILE_TEST to better catch
this kind of bugs in the future.

Alban
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] reset: ath79: Add system restart support Alban Bedel <albeu@free.fr> - 2015-11-24 01:10 +0100
  Re: [PATCH] reset: ath79: Add system restart support Philipp Zabel <p.zabel@pengutronix.de> - 2015-11-24 13:10 +0100
    Re: [PATCH] reset: ath79: Add system restart support Alban <albeu@free.fr> - 2015-11-24 19:40 +0100

csiph-web