Re: [PATCH] dmaengine: bcm2835-dma: Convert to use DMA pool

From	Eric Anholt <eric@anholt.net>
Newsgroups	linux.kernel
Subject	Re: [PATCH] dmaengine: bcm2835-dma: Convert to use DMA pool
Date	2015-11-24 19:40 +0100
Message-ID	<qyqFs-3m4-19@gated-at.bofh.it> (permalink)
References	<qvpPA-6yp-17@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

[Multipart message — attachments visible in raw view] - view raw

Peter Ujfalusi <peter.ujfalusi@ti.com> writes:

> f93178291712 dmaengine: bcm2835-dma: Fix memory leak when stopping a
> 	     running transfer
>
> Fixed the memleak, but introduced another issue: the terminate_all callback
> might be called with interrupts disabled and the dma_free_coherent() is
> not allowed to be called when IRQs are disabled.
> Convert the driver to use dma_pool_* for managing the list of control
> blocks for the transfer.
>
> Fixes: f93178291712 ("dmaengine: bcm2835-dma: Fix memory leak when stopping a running transfer")
> Signed-off-by: Peter Ujfalusi <peter.ujfalusi@ti.com>

It sounds like you got positive testing feedback.  Using the DMA pool
for our bcm2835_dma_cbs makes sense to me, too.

Reviewed-by: Eric Anholt <eric@anholt.net>

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] dmaengine: bcm2835-dma: Convert to use DMA pool Peter Ujfalusi <peter.ujfalusi@ti.com> - 2015-11-16 12:10 +0100
  Re: [PATCH] dmaengine: bcm2835-dma: Convert to use DMA pool Peter Ujfalusi <peter.ujfalusi@ti.com> - 2015-11-17 08:50 +0100
    Re: [PATCH] dmaengine: bcm2835-dma: Convert to use DMA pool Stefan Wahren <info@lategoodbye.de> - 2015-11-17 10:10 +0100
      Re: [PATCH] dmaengine: bcm2835-dma: Convert to use DMA pool Peter Ujfalusi <peter.ujfalusi@ti.com> - 2015-11-17 10:30 +0100
  Re: [PATCH] dmaengine: bcm2835-dma: Convert to use DMA pool Eric Anholt <eric@anholt.net> - 2015-11-24 19:40 +0100

csiph-web