Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1276007

Re: [PATCH 00/71] More fixes, cleanup and modernization for NCR5380 drivers

From Finn Thain <fthain@telegraphics.com.au>
Newsgroups linux.kernel
Subject Re: [PATCH 00/71] More fixes, cleanup and modernization for NCR5380 drivers
Date 2015-11-24 02:30 +0100
Message-ID <qyaAH-1iQ-13@gated-at.bofh.it> (permalink)
References <qw6Bc-vx-5@gated-at.bofh.it> <qxg5r-5GU-11@gated-at.bofh.it> <qxpV8-3RO-15@gated-at.bofh.it> <qy8fw-89o-17@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


On Mon, 23 Nov 2015, Ondrej Zary wrote:

> 
> PDMA seems to be broken in multiple ways. NCR5380_pread cannot process 
> less than 128 bytes. In fact, 53C400 datasheet says that it's HW 
> limitation: non-modulo-128-byte transfers should use PIO.
> 
> Adding
>         transfersize = round_down(transfersize, 128);
> to generic_NCR5380_dma_xfer_len() improves the situation a bit.
> 
> After modprobe, some small reads (8, 4, 24 and 64 bytes) are done using 
> PIO, then eight 512-byte reads using PDMA and then it fails on a 
> 254-byte read. First 128 bytes are read using PDMA and the next PDMA 
> operation hangs waiting forever for the host buffer to be ready.
> 

A 128-byte PDMA receive followed by 126-byte PDMA receive? I don't see how
that is possible given round_down(126, 128) == 0. Was this the actual
'len' argument to NCR5380_pread() in g_NCR5380.c?

BTW, I presume that FLAG_NO_DMA_FIXUPS was set (which is the case if you
pass ncr_53c400=1 option with modprobe). Otherwise you could see PDMA IO
sizes like 127 etc.

-- 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | NextPrevious in thread | Next in thread | Find similar | Unroll thread


Thread

[PATCH 00/71] More fixes, cleanup and modernization for NCR5380 drivers Finn Thain <fthain@telegraphics.com.au> - 2015-11-18 10:20 +0100
  [PATCH 04/71] ncr5380: Remove more pointless macros Finn Thain <fthain@telegraphics.com.au> - 2015-11-18 10:30 +0100
  Re: [PATCH 00/71] More fixes, cleanup and modernization for NCR5380 drivers Ondrej Zary <linux@rainbow-software.org> - 2015-11-18 12:40 +0100
    Re: [PATCH 00/71] More fixes, cleanup and modernization for NCR5380  drivers Finn Thain <fthain@telegraphics.com.au> - 2015-11-19 03:30 +0100
      Re: [PATCH 00/71] More fixes, cleanup and modernization for NCR5380  drivers Michael Schmitz <schmitzmic@gmail.com> - 2015-11-19 04:00 +0100
      Re: [PATCH 00/71] More fixes, cleanup and modernization for NCR5380 drivers Ondrej Zary <linux@rainbow-software.org> - 2015-11-19 08:50 +0100
      Re: [PATCH 00/71] More fixes, cleanup and modernization for NCR5380 drivers Ondrej Zary <linux@rainbow-software.org> - 2015-11-20 00:00 +0100
        Re: [PATCH 00/71] More fixes, cleanup and modernization for NCR5380  drivers Finn Thain <fthain@telegraphics.com.au> - 2015-11-20 02:50 +0100
          Re: [PATCH 00/71] More fixes, cleanup and modernization for NCR5380  drivers Finn Thain <fthain@telegraphics.com.au> - 2015-11-20 08:30 +0100
            Re: [PATCH 00/71] More fixes, cleanup and modernization for NCR5380  drivers Christoph Hellwig <hch@infradead.org> - 2015-11-20 08:40 +0100
              Re: [PATCH 00/71] More fixes, cleanup and modernization for NCR5380  drivers Finn Thain <fthain@telegraphics.com.au> - 2015-11-20 09:20 +0100
                Re: [PATCH 00/71] More fixes, cleanup and modernization for NCR5380 drivers Ondrej Zary <linux@rainbow-software.org> - 2015-11-20 10:20 +0100
                Re: [PATCH 00/71] More fixes, cleanup and modernization for NCR5380  drivers Christoph Hellwig <hch@infradead.org> - 2015-11-20 11:10 +0100
                Re: [PATCH 00/71] More fixes, cleanup and modernization for NCR5380  drivers Finn Thain <fthain@telegraphics.com.au> - 2015-11-20 12:00 +0100
                Re: [PATCH 00/71] More fixes, cleanup and modernization for NCR5380  drivers Christoph Hellwig <hch@infradead.org> - 2015-11-20 12:50 +0100
                Re: [PATCH 00/71] More fixes, cleanup and modernization for NCR5380 drivers Ondrej Zary <linux@rainbow-software.org> - 2015-11-20 12:50 +0100
                Re: [PATCH 00/71] More fixes, cleanup and modernization for NCR5380 drivers Geert Uytterhoeven <geert@linux-m68k.org> - 2015-11-20 13:30 +0100
                Re: [PATCH 00/71] More fixes, cleanup and modernization for NCR5380 drivers Ondrej Zary <linux@rainbow-software.org> - 2015-11-20 13:50 +0100
          Re: [PATCH 00/71] More fixes, cleanup and modernization for NCR5380 drivers Ondrej Zary <linux@rainbow-software.org> - 2015-11-20 08:40 +0100
          Re: [PATCH 00/71] More fixes, cleanup and modernization for NCR5380 drivers Ondrej Zary <linux@rainbow-software.org> - 2015-11-20 19:30 +0100
            Re: [PATCH 00/71] More fixes, cleanup and modernization for NCR5380  drivers Finn Thain <fthain@telegraphics.com.au> - 2015-11-21 03:10 +0100
              Re: [PATCH 00/71] More fixes, cleanup and modernization for NCR5380 drivers Ondrej Zary <linux@rainbow-software.org> - 2015-11-21 14:10 +0100
                Re: [PATCH 00/71] More fixes, cleanup and modernization for NCR5380 drivers Ondrej Zary <linux@rainbow-software.org> - 2015-11-22 00:10 +0100
                Re: [PATCH 00/71] More fixes, cleanup and modernization for NCR5380  drivers Finn Thain <fthain@telegraphics.com.au> - 2015-11-22 00:40 +0100
                Re: [PATCH 00/71] More fixes, cleanup and modernization for NCR5380 drivers Ondrej Zary <linux@rainbow-software.org> - 2015-11-24 00:00 +0100
                Re: [PATCH 00/71] More fixes, cleanup and modernization for NCR5380  drivers Finn Thain <fthain@telegraphics.com.au> - 2015-11-24 02:30 +0100
                Re: [PATCH 00/71] More fixes, cleanup and modernization for NCR5380 drivers Ondrej Zary <linux@rainbow-software.org> - 2015-11-24 09:10 +0100
                Re: [PATCH 00/71] More fixes, cleanup and modernization for NCR5380  drivers Finn Thain <fthain@telegraphics.com.au> - 2015-11-24 10:20 +0100
                Re: [PATCH 00/71] More fixes, cleanup and modernization for NCR5380 drivers Ondrej Zary <linux@rainbow-software.org> - 2015-11-24 13:10 +0100
                Re: [PATCH 00/71] More fixes, cleanup and modernization for NCR5380 drivers Ondrej Zary <linux@rainbow-software.org> - 2015-11-24 19:10 +0100
                Re: [PATCH 00/71] More fixes, cleanup and modernization for NCR5380 drivers Ondrej Zary <linux@rainbow-software.org> - 2015-11-24 22:50 +0100
                Re: [PATCH 00/71] More fixes, cleanup and modernization for NCR5380  drivers Finn Thain <fthain@telegraphics.com.au> - 2015-11-25 03:20 +0100
                Re: [PATCH 00/71] More fixes, cleanup and modernization for NCR5380 drivers Ondrej Zary <linux@rainbow-software.org> - 2015-11-25 10:10 +0100
                Re: [PATCH 00/71] More fixes, cleanup and modernization for NCR5380  drivers Finn Thain <fthain@telegraphics.com.au> - 2015-11-25 13:00 +0100
                Re: [PATCH 00/71] More fixes, cleanup and modernization for NCR5380 drivers Ondrej Zary <linux@rainbow-software.org> - 2015-11-26 00:10 +0100
  [PATCH 72/71] ncr5380: Fix pseudo-DMA Ondrej Zary <linux@rainbow-software.org> - 2015-11-25 22:40 +0100
  [RFC PATCH 73/71] ncr5380: Use runtime register mapping Ondrej Zary <linux@rainbow-software.org> - 2015-11-29 10:50 +0100
    Re: [RFC PATCH 73/71] ncr5380: Use runtime register mapping Finn Thain <fthain@telegraphics.com.au> - 2015-11-30 13:00 +0100
  [RFC PATCH 74/71] ncr5380: Enable PDMA for NCR53C400A Ondrej Zary <linux@rainbow-software.org> - 2015-11-29 10:50 +0100
    Re: [RFC PATCH 74/71] ncr5380: Enable PDMA for NCR53C400A Finn Thain <fthain@telegraphics.com.au> - 2015-11-30 13:00 +0100
    Re: [RFC PATCH 74/71] ncr5380: Enable PDMA for NCR53C400A Finn Thain <fthain@telegraphics.com.au> - 2015-11-30 13:10 +0100
      Re: [RFC PATCH 74/71] ncr5380: Enable PDMA for NCR53C400A Ondrej Zary <linux@rainbow-software.org> - 2015-11-30 14:50 +0100
  [RFC PATCH 75/71] ncr5380: Remove FLAG_DTC3181E Ondrej Zary <linux@rainbow-software.org> - 2015-11-29 11:10 +0100
    Re: [RFC PATCH 75/71] ncr5380: Remove FLAG_DTC3181E Finn Thain <fthain@telegraphics.com.au> - 2015-11-30 06:00 +0100

csiph-web