Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1276006

Re: [PATCH] thermal: exynos: use of_property_read_u8()

Show all headers | View raw

On 24.11.2015 08:29, Eduardo Valentin wrote:
> On Mon, Nov 23, 2015 at 07:40:41PM +0530, Saurabh Sengar wrote:
>> use of_property_read_u8() for u8 variables,
>> also changed the return type to void as this function return type
>> is nowhere used.
>>
> 
> I would be good if you could split both changes into two patches.
> 
> Also, I still do not understand properly the proposal to use u8.
> 
> Why are they u8?
> 
> If they are so, please document them in their DT bindings. Today, the
> bindings tell us they are s32 (as there is nothing really specifying the
> type).

It looks like u8 came from platform data from old times when the driver
did not support DT. All of our Exynos mainline boards are converted to
DT, so I think legacy platform data can be also changed to match DT.
Which means changing from u8 to u32.

Best regards,
Krzysztof


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] thermal: exynos: use of_property_read_u8() Saurabh Sengar <saurabh.truth@gmail.com> - 2015-11-23 15:20 +0100
  Re: [PATCH] thermal: exynos: use of_property_read_u8() Eduardo Valentin <edubezval@gmail.com> - 2015-11-24 00:30 +0100
    Re: [PATCH] thermal: exynos: use of_property_read_u8() Krzysztof Kozlowski <k.kozlowski@samsung.com> - 2015-11-24 02:30 +0100

csiph-web