Re: [PATCH v2] zram: Prevent page allocation failure during zcomp_strm_alloc

From	Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH v2] zram: Prevent page allocation failure during zcomp_strm_alloc
Date	2015-11-23 04:40 +0100
Message-ID	<qxQ8V-4HC-5@gated-at.bofh.it> (permalink)
References	<qwQNI-5O7-23@gated-at.bofh.it> <qxOTw-3RV-1@gated-at.bofh.it> <qxPPz-4A6-9@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On (11/23/15 12:14), Sergey Senozhatsky wrote:
> 
> yes, GFP_KERNEL looks a bit fragile to me too. And may be zcomp_strm_alloc()
> and comp->backend->create() deserve GFP_NOFS. I believe I sent a patch doing
> this a while ago: https://lkml.org/lkml/2015/6/16/465
>

perhaps just __GFP_RECLAIM (GFP_NOIO), not  '__GFP_RECLAIM | __GFP_IO'
(GFP_NOFS), is better.

	-ss
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH v2] zram: Prevent page allocation failure during zcomp_strm_alloc Kyeongdon Kim <kyeongdon.kim@lge.com> - 2015-11-20 11:10 +0100
  Re: [PATCH v2] zram: Prevent page allocation failure during  zcomp_strm_alloc Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com> - 2015-11-21 03:20 +0100
    Re: [PATCH v2] zram: Prevent page allocation failure during  zcomp_strm_alloc Sergey Senozhatsky <sergey.senozhatsky@gmail.com> - 2015-11-21 10:40 +0100
  Re: [PATCH v2] zram: Prevent page allocation failure during  zcomp_strm_alloc Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com> - 2015-11-21 03:20 +0100
  Re: [PATCH v2] zram: Prevent page allocation failure during  zcomp_strm_alloc Minchan Kim <minchan@kernel.org> - 2015-11-23 03:20 +0100
    Re: [PATCH v2] zram: Prevent page allocation failure during  zcomp_strm_alloc Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com> - 2015-11-23 04:20 +0100
      Re: [PATCH v2] zram: Prevent page allocation failure during  zcomp_strm_alloc Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com> - 2015-11-23 04:40 +0100

csiph-web