Re: [PATCH v2] zram: Prevent page allocation failure during zcomp_strm_alloc

From	Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH v2] zram: Prevent page allocation failure during zcomp_strm_alloc
Date	2015-11-23 04:20 +0100
Message-ID	<qxPPz-4A6-9@gated-at.bofh.it> (permalink)
References	<qwQNI-5O7-23@gated-at.bofh.it> <qxOTw-3RV-1@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

Hello,

On (11/23/15 11:15), Minchan Kim wrote:
[..]
> >  static void *zcomp_lz4_create(void)
> >  {
> > -	return kzalloc(LZ4_MEM_COMPRESS, GFP_KERNEL);
> > +	void *ret;
> > +
> > +	ret = kzalloc(LZ4_MEM_COMPRESS,
> > +			__GFP_NORETRY|__GFP_NOWARN|__GFP_NOMEMALLOC);
> > +	if (!ret)
> > +		ret = vzalloc(LZ4_MEM_COMPRESS);
> 
> One thing I feel bad smell is that call vzalloc with GFP_KERNEL.
> This function can be called in direct reclaim path with holding
> fs lock and GFP_KERNEL can enter recursive reclaim path so
> lockdep would complain theoretically if I don't miss something.
> 

yes, GFP_KERNEL looks a bit fragile to me too. And may be zcomp_strm_alloc()
and comp->backend->create() deserve GFP_NOFS. I believe I sent a patch doing
this a while ago: https://lkml.org/lkml/2015/6/16/465

> If it is true, we should fix several allocation flags in
> zcomp_strm_alloc. I just want to record this warning for the future
> in this thread so someone who is finding for the contribution
> material will prove and fix it. :)

I can re-send the patch.

And, in case if you missed it, what's your opinion on the idea of
reducing ->max_strm if we can't allocate new streams. Here:
http://marc.info/?l=linux-kernel&m=144798049429861

	-ss
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Thread

[PATCH v2] zram: Prevent page allocation failure during zcomp_strm_alloc Kyeongdon Kim <kyeongdon.kim@lge.com> - 2015-11-20 11:10 +0100
  Re: [PATCH v2] zram: Prevent page allocation failure during  zcomp_strm_alloc Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com> - 2015-11-21 03:20 +0100
    Re: [PATCH v2] zram: Prevent page allocation failure during  zcomp_strm_alloc Sergey Senozhatsky <sergey.senozhatsky@gmail.com> - 2015-11-21 10:40 +0100
  Re: [PATCH v2] zram: Prevent page allocation failure during  zcomp_strm_alloc Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com> - 2015-11-21 03:20 +0100
  Re: [PATCH v2] zram: Prevent page allocation failure during  zcomp_strm_alloc Minchan Kim <minchan@kernel.org> - 2015-11-23 03:20 +0100
    Re: [PATCH v2] zram: Prevent page allocation failure during  zcomp_strm_alloc Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com> - 2015-11-23 04:20 +0100
      Re: [PATCH v2] zram: Prevent page allocation failure during  zcomp_strm_alloc Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com> - 2015-11-23 04:40 +0100

csiph-web