Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1273220

Re: [PATCH v3 2/5] dt-bindings: soc: add document for rockchip reboot notifier driver

Show all headers | View raw

[Multipart message — attachments visible in raw view] - view raw

On Thu, Nov 19, 2015 at 09:39:02PM +0800, Andy Yan wrote:
> Hi Thierry:
> 
> 2015-11-19 20:56 GMT+08:00 Thierry Reding <treding@nvidia.com>:
> 
> > On Thu, Nov 19, 2015 at 09:17:37AM +0800, Andy Yan wrote:
> > > Hi Rob:
> > >
> > > On 2015年11月19日 06:59, Rob Herring wrote:
> > > >On Wed, Nov 18, 2015 at 05:53:30PM +0800, Andy Yan wrote:
> > > >>Add devicetree binding document for rockchip reboot nofifier driver
> > > >Just reading the subject this is way too specific to the Linux driver
> > > >needs rather than a h/w description. Please don't create fake DT nodes
> > > >just to bind to drivers. Whatever &pmu is is probably what should have
> > > >the DT node. Let the driver for it create child devices if you need
> > > >that.
> > >
> > >     This is note a fake DT nodes, we really need it to tell the driver
> > >      which register to use to store the reboot mode. Because rockchip
> > >      use different register file to store the reboot mode on different
> > >      platform, on rk3066,rk3188, rk3288,it use  one of the PMU register,
> > on
> > >      the incoming RK3036, it use one of the GRF register, and it use
> > one  of
> > >      the PMUGRF register for arm64 platform rk3368. On the other hand,
> > the
> > >      PMU/GRF/PMUGRF register file are mapped as "syscon", then referenced
> > >      by other DT nodes by phandle. So maybe let it as a separate DT node
> > > here
> > >      is better.
> >
> > In that case you should probably implement a reboot notifier in each of
> > the drivers you list and depending on the generation of the SoC. You can
> > easily parameterize this by matching on the compatible string.
> >
> > Thierry
> >
> 
>  There is no rockchip specific driver for PMU/GRF/PMUGRF register file I
> list above， they
>  use the generic driver “syscon”

Well, just go and write specific drivers, then.

Thierry

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH v3 0/5] Add reboot notifier driver for rockchip platform Andy Yan <andy.yan@rock-chips.com> - 2015-11-18 10:50 +0100
  [PATCH v3 3/5] soc: rockchip: add reboot notifier driver Andy Yan <andy.yan@rock-chips.com> - 2015-11-18 11:00 +0100
  [PATCH v3 2/5] dt-bindings: soc: add document for rockchip reboot notifier driver Andy Yan <andy.yan@rock-chips.com> - 2015-11-18 11:00 +0100
    Re: [PATCH v3 2/5] dt-bindings: soc: add document for rockchip  reboot notifier driver Rob Herring <robh@kernel.org> - 2015-11-19 00:00 +0100
      Re: [PATCH v3 2/5] dt-bindings: soc: add document for rockchip reboot  notifier driver Andy Yan <andy.yan@rock-chips.com> - 2015-11-19 02:20 +0100
        Re: [PATCH v3 2/5] dt-bindings: soc: add document for rockchip reboot notifier driver Heiko Stuebner <heiko@sntech.de> - 2015-11-19 05:40 +0100
          Re: [PATCH v3 2/5] dt-bindings: soc: add document for rockchip reboot  notifier driver Andy Yan <andy.yan@rock-chips.com> - 2015-11-20 02:20 +0100
            Re: [PATCH v3 2/5] dt-bindings: soc: add document for rockchip reboot  notifier driver Rob Herring <robh@kernel.org> - 2015-11-20 03:00 +0100
        Re: [PATCH v3 2/5] dt-bindings: soc: add document for rockchip  reboot notifier driver Thierry Reding <treding@nvidia.com> - 2015-11-19 14:00 +0100
          Re: [PATCH v3 2/5] dt-bindings: soc: add document for rockchip  reboot notifier driver Thierry Reding <treding@nvidia.com> - 2015-11-19 16:40 +0100
  [PATCH v3 1/5] ARM: dts: rockchip: rk3288-veyron: rename pinctrl node reboot to reset Andy Yan <andy.yan@rock-chips.com> - 2015-11-18 11:00 +0100
    Re: [PATCH v3 1/5] ARM: dts: rockchip: rk3288-veyron: rename pinctrl  node reboot to reset Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> - 2015-11-18 15:20 +0100
  [PATCH v3 4/5] ARM: dts: rockchip: add reboot node Andy Yan <andy.yan@rock-chips.com> - 2015-11-18 11:10 +0100
  [PATCH v3 5/5] ARM64: dts: rockchip: add reboot node Andy Yan <andy.yan@rock-chips.com> - 2015-11-18 11:10 +0100

csiph-web