Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1272656

Re: [PATCH v3 2/5] dt-bindings: soc: add document for rockchip reboot notifier driver

Show all headers | View raw

On Wed, Nov 18, 2015 at 05:53:30PM +0800, Andy Yan wrote:
> Add devicetree binding document for rockchip reboot nofifier driver

Just reading the subject this is way too specific to the Linux driver 
needs rather than a h/w description. Please don't create fake DT nodes 
just to bind to drivers. Whatever &pmu is is probably what should have 
the DT node. Let the driver for it create child devices if you need 
that.

Rob
> 
> Signed-off-by: Andy Yan <andy.yan@rock-chips.com>
> 
> ---
> 
> Changes in v3:
>  - add dt binding
> 
> Changes in v2: None
> 
>  .../bindings/soc/rockchip/rockchip-reboot.txt          | 18 ++++++++++++++++++
>  1 file changed, 18 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/soc/rockchip/rockchip-reboot.txt
> 
> diff --git a/Documentation/devicetree/bindings/soc/rockchip/rockchip-reboot.txt b/Documentation/devicetree/bindings/soc/rockchip/rockchip-reboot.txt
> new file mode 100644
> index 0000000..6f69c8d
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/soc/rockchip/rockchip-reboot.txt
> @@ -0,0 +1,18 @@
> +Rockchip reboot notifier driver
> +
> +This driver get reboot mode arguments from userspace
> +and stores it in special register. Then the bootloader
> +will read it and take different action according the
> +argument stored.
> +
> +Required properties:
> +- compatible: should be "rockchip,reboot"
> +- regmap: this is phandle to the register map node
> +- offset: offset in the register map for the storage register (in bytes)
> +
> +Examples:
> +	reboot {
> +	   compatible = "rockchip,reboot";
> +	   regmap = <&pmu>;
> +	   offset = <0x94>;
> +	};
> -- 
> 1.9.1
> 
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH v3 0/5] Add reboot notifier driver for rockchip platform Andy Yan <andy.yan@rock-chips.com> - 2015-11-18 10:50 +0100
  [PATCH v3 3/5] soc: rockchip: add reboot notifier driver Andy Yan <andy.yan@rock-chips.com> - 2015-11-18 11:00 +0100
  [PATCH v3 2/5] dt-bindings: soc: add document for rockchip reboot notifier driver Andy Yan <andy.yan@rock-chips.com> - 2015-11-18 11:00 +0100
    Re: [PATCH v3 2/5] dt-bindings: soc: add document for rockchip  reboot notifier driver Rob Herring <robh@kernel.org> - 2015-11-19 00:00 +0100
      Re: [PATCH v3 2/5] dt-bindings: soc: add document for rockchip reboot  notifier driver Andy Yan <andy.yan@rock-chips.com> - 2015-11-19 02:20 +0100
        Re: [PATCH v3 2/5] dt-bindings: soc: add document for rockchip reboot notifier driver Heiko Stuebner <heiko@sntech.de> - 2015-11-19 05:40 +0100
          Re: [PATCH v3 2/5] dt-bindings: soc: add document for rockchip reboot  notifier driver Andy Yan <andy.yan@rock-chips.com> - 2015-11-20 02:20 +0100
            Re: [PATCH v3 2/5] dt-bindings: soc: add document for rockchip reboot  notifier driver Rob Herring <robh@kernel.org> - 2015-11-20 03:00 +0100
        Re: [PATCH v3 2/5] dt-bindings: soc: add document for rockchip  reboot notifier driver Thierry Reding <treding@nvidia.com> - 2015-11-19 14:00 +0100
          Re: [PATCH v3 2/5] dt-bindings: soc: add document for rockchip  reboot notifier driver Thierry Reding <treding@nvidia.com> - 2015-11-19 16:40 +0100
  [PATCH v3 1/5] ARM: dts: rockchip: rk3288-veyron: rename pinctrl node reboot to reset Andy Yan <andy.yan@rock-chips.com> - 2015-11-18 11:00 +0100
    Re: [PATCH v3 1/5] ARM: dts: rockchip: rk3288-veyron: rename pinctrl  node reboot to reset Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> - 2015-11-18 15:20 +0100
  [PATCH v3 4/5] ARM: dts: rockchip: add reboot node Andy Yan <andy.yan@rock-chips.com> - 2015-11-18 11:10 +0100
  [PATCH v3 5/5] ARM64: dts: rockchip: add reboot node Andy Yan <andy.yan@rock-chips.com> - 2015-11-18 11:10 +0100

csiph-web