Re: [PATCH 02/13] dmaengine: Introduce dma_request_slave_channel_compat_reason()

From	Vinod Koul <vinod.koul@intel.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH 02/13] dmaengine: Introduce dma_request_slave_channel_compat_reason()
Date	2015-11-18 17:10 +0100
Message-ID	<qwdsZ-5eU-13@gated-at.bofh.it> (permalink)
References	<pun5D-5jv-3@gated-at.bofh.it> <qwcwW-4zt-17@gated-at.bofh.it> <qwd9D-4Pa-7@gated-at.bofh.it> <qwdjl-4US-25@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Wed, Nov 18, 2015 at 04:51:54PM +0100, Arnd Bergmann wrote:
> On Wednesday 18 November 2015 17:43:04 Andy Shevchenko wrote:
> > >
> > > I assume that the sst-firmware.c case is a mistake, it should just use a
> > > plain DMA_SLAVE and not DMA_MEMCPY.
> > 
> > Other way around.
> > 
> 
> Ok, I see. In that case I guess it also shouldn't call
> dmaengine_slave_config(), right? I don't think that's valid
> on a MEMCPY channel.

Yes it is not valid. In this case the dma driver should invoke a generic memcpy
and not need slave parameters, knowing the hw and reason for this (firmware
download to DSP memory), this doesn't qualify for slave case.
In fact filter function doesn't need a channel, any channel in this
controller will be good

-- 
~Vinod
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Thread

Re: [PATCH 02/13] dmaengine: Introduce dma_request_slave_channel_compat_reason() Arnd Bergmann <arnd@arndb.de> - 2015-11-18 15:30 +0100
  Re: [PATCH 02/13] dmaengine: Introduce  dma_request_slave_channel_compat_reason() Peter Ujfalusi <peter.ujfalusi@ti.com> - 2015-11-18 15:50 +0100
    Re: [PATCH 02/13] dmaengine: Introduce dma_request_slave_channel_compat_reason() Arnd Bergmann <arnd@arndb.de> - 2015-11-18 16:10 +0100
      Re: [PATCH 02/13] dmaengine: Introduce dma_request_slave_channel_compat_reason() Andy Shevchenko <andy.shevchenko@gmail.com> - 2015-11-18 16:50 +0100
        Re: [PATCH 02/13] dmaengine: Introduce dma_request_slave_channel_compat_reason() Arnd Bergmann <arnd@arndb.de> - 2015-11-18 17:00 +0100
          Re: [PATCH 02/13] dmaengine: Introduce dma_request_slave_channel_compat_reason() Andy Shevchenko <andy.shevchenko@gmail.com> - 2015-11-18 17:10 +0100
          Re: [PATCH 02/13] dmaengine: Introduce  dma_request_slave_channel_compat_reason() Vinod Koul <vinod.koul@intel.com> - 2015-11-18 17:10 +0100
      Re: [PATCH 02/13] dmaengine: Introduce  dma_request_slave_channel_compat_reason() Peter Ujfalusi <peter.ujfalusi@ti.com> - 2015-11-19 11:40 +0100
        Re: [PATCH 02/13] dmaengine: Introduce dma_request_slave_channel_compat_reason() Arnd Bergmann <arnd@arndb.de> - 2015-11-19 12:30 +0100
          Re: [PATCH 02/13] dmaengine: Introduce  dma_request_slave_channel_compat_reason() Peter Ujfalusi <peter.ujfalusi@ti.com> - 2015-11-20 11:30 +0100
            Re: [PATCH 02/13] dmaengine: Introduce dma_request_slave_channel_compat_reason() Arnd Bergmann <arnd@arndb.de> - 2015-11-20 12:00 +0100
              Re: [PATCH 02/13] dmaengine: Introduce dma_request_slave_channel_compat_reason() Andy Shevchenko <andy.shevchenko@gmail.com> - 2015-11-20 13:30 +0100
                Re: [PATCH 02/13] dmaengine: Introduce  dma_request_slave_channel_compat_reason() Peter Ujfalusi <peter.ujfalusi@ti.com> - 2015-11-20 13:40 +0100
                Re: [PATCH 02/13] dmaengine: Introduce dma_request_slave_channel_compat_reason() Andy Shevchenko <andy.shevchenko@gmail.com> - 2015-11-20 15:10 +0100
              Re: [PATCH 02/13] dmaengine: Introduce  dma_request_slave_channel_compat_reason() Peter Ujfalusi <peter.ujfalusi@ti.com> - 2015-11-20 14:00 +0100
                Re: [PATCH 02/13] dmaengine: Introduce dma_request_slave_channel_compat_reason() Arnd Bergmann <arnd@arndb.de> - 2015-11-20 14:50 +0100

csiph-web