Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1272213

Re: [PATCH 02/13] dmaengine: Introduce dma_request_slave_channel_compat_reason()

Show all headers | View raw

On Wednesday 18 November 2015 16:21:26 Peter Ujfalusi wrote:
> 2. non slave channel requests, where only the functionality matters, like
> memcpy, interleaved, memset, etc.
> We could have a simple:
> dma_request_channel(mask);
> 
> But looking at the drivers using dmaengine legacy dma_request_channel() API:
> Some sets DMA_INTERRUPT or DMA_PRIVATE or DMA_SG along with DMA_SLAVE:
> drivers/misc/carma/carma-fpga.c                 DMA_INTERRUPT|DMA_SLAVE|DMA_SG
> drivers/misc/carma/carma-fpga-program.c         DMA_MEMCPY|DMA_SLAVE|DMA_SG
> drivers/media/platform/soc_camera/mx3_camera.c  DMA_SLAVE|DMA_PRIVATE
> sound/soc/intel/common/sst-firmware.c           DMA_SLAVE|DMA_MEMCPY
> 
> as examples.
> Not sure how valid are these...

It's usually not much harder to separate out the legacy case from
the normal dma_request_slave_channel_reason(), so those drivers don't
really need to use the unified compat API.

	Arnd
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

Re: [PATCH 02/13] dmaengine: Introduce dma_request_slave_channel_compat_reason() Arnd Bergmann <arnd@arndb.de> - 2015-11-18 15:30 +0100
  Re: [PATCH 02/13] dmaengine: Introduce  dma_request_slave_channel_compat_reason() Peter Ujfalusi <peter.ujfalusi@ti.com> - 2015-11-18 15:50 +0100
    Re: [PATCH 02/13] dmaengine: Introduce dma_request_slave_channel_compat_reason() Arnd Bergmann <arnd@arndb.de> - 2015-11-18 16:10 +0100
      Re: [PATCH 02/13] dmaengine: Introduce dma_request_slave_channel_compat_reason() Andy Shevchenko <andy.shevchenko@gmail.com> - 2015-11-18 16:50 +0100
        Re: [PATCH 02/13] dmaengine: Introduce dma_request_slave_channel_compat_reason() Arnd Bergmann <arnd@arndb.de> - 2015-11-18 17:00 +0100
          Re: [PATCH 02/13] dmaengine: Introduce dma_request_slave_channel_compat_reason() Andy Shevchenko <andy.shevchenko@gmail.com> - 2015-11-18 17:10 +0100
          Re: [PATCH 02/13] dmaengine: Introduce  dma_request_slave_channel_compat_reason() Vinod Koul <vinod.koul@intel.com> - 2015-11-18 17:10 +0100
      Re: [PATCH 02/13] dmaengine: Introduce  dma_request_slave_channel_compat_reason() Peter Ujfalusi <peter.ujfalusi@ti.com> - 2015-11-19 11:40 +0100
        Re: [PATCH 02/13] dmaengine: Introduce dma_request_slave_channel_compat_reason() Arnd Bergmann <arnd@arndb.de> - 2015-11-19 12:30 +0100
          Re: [PATCH 02/13] dmaengine: Introduce  dma_request_slave_channel_compat_reason() Peter Ujfalusi <peter.ujfalusi@ti.com> - 2015-11-20 11:30 +0100
            Re: [PATCH 02/13] dmaengine: Introduce dma_request_slave_channel_compat_reason() Arnd Bergmann <arnd@arndb.de> - 2015-11-20 12:00 +0100
              Re: [PATCH 02/13] dmaengine: Introduce dma_request_slave_channel_compat_reason() Andy Shevchenko <andy.shevchenko@gmail.com> - 2015-11-20 13:30 +0100
                Re: [PATCH 02/13] dmaengine: Introduce  dma_request_slave_channel_compat_reason() Peter Ujfalusi <peter.ujfalusi@ti.com> - 2015-11-20 13:40 +0100
                Re: [PATCH 02/13] dmaengine: Introduce dma_request_slave_channel_compat_reason() Andy Shevchenko <andy.shevchenko@gmail.com> - 2015-11-20 15:10 +0100
              Re: [PATCH 02/13] dmaengine: Introduce  dma_request_slave_channel_compat_reason() Peter Ujfalusi <peter.ujfalusi@ti.com> - 2015-11-20 14:00 +0100
                Re: [PATCH 02/13] dmaengine: Introduce dma_request_slave_channel_compat_reason() Arnd Bergmann <arnd@arndb.de> - 2015-11-20 14:50 +0100

csiph-web