Re: [PATCH v3 1/1] i2c: taos-evm: replace simple_strtoul by kstrtou8

From	Andy Shevchenko <andy.shevchenko@gmail.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH v3 1/1] i2c: taos-evm: replace simple_strtoul by kstrtou8
Date	2015-11-18 17:30 +0100
Message-ID	<qwdMm-5n6-11@gated-at.bofh.it> (permalink)
References	<qwav8-2Zg-5@gated-at.bofh.it> <qwav8-2Zg-9@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Wed, Nov 18, 2015 at 2:55 PM, LABBE Corentin
<clabbe.montjoie@gmail.com> wrote:
> The simple_strtoul function is marked as obsolete.
> This patch replace it by kstrtou8.
>

Only one concern. simple_strto* goes through the string until it has
an invalid character or \0. In your case kstrtou8 will fail the
transfer. So, is there possible cases when HW returns such data?

And just a style nitpicks below.

>                 if (p[0] == 'x') {
> -                       data->byte = simple_strtol(p + 1, NULL, 16);
> +                       /*
> +                        * voluntarily dropping error code of kstrtou8 since all

-> Voluntarily…

> +                        * error code that it could return are invalid according
> +                        * to Documentation/i2c/fault-codes

-> …codes.

> +                        */
> +                       if (kstrtou8(p + 1, 16, &data->byte))
> +                               return -EPROTO;

-- 
With Best Regards,
Andy Shevchenko
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Thread

[PATCH v3 1/1] i2c: taos-evm: replace simple_strtoul by kstrtou8 LABBE Corentin <clabbe.montjoie@gmail.com> - 2015-11-18 14:00 +0100
  Re: [PATCH v3 1/1] i2c: taos-evm: replace simple_strtoul by kstrtou8 Andy Shevchenko <andy.shevchenko@gmail.com> - 2015-11-18 17:30 +0100
    Re: [PATCH v3 1/1] i2c: taos-evm: replace simple_strtoul by  kstrtou8 Jean Delvare <jdelvare@suse.de> - 2015-11-21 21:20 +0100
  Re: [PATCH v3 1/1] i2c: taos-evm: replace simple_strtoul by  kstrtou8 Jean Delvare <jdelvare@suse.de> - 2015-11-21 21:20 +0100

csiph-web