[PATCH v3 1/1] i2c: taos-evm: replace simple_strtoul by kstrtou8

From	LABBE Corentin <clabbe.montjoie@gmail.com>
Newsgroups	linux.kernel
Subject	[PATCH v3 1/1] i2c: taos-evm: replace simple_strtoul by kstrtou8
Date	2015-11-18 14:00 +0100
Message-ID	<qwav8-2Zg-9@gated-at.bofh.it> (permalink)
References	<qwav8-2Zg-5@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

The simple_strtoul function is marked as obsolete.
This patch replace it by kstrtou8.

Signed-off-by: LABBE Corentin <clabbe.montjoie@gmail.com>
---
 drivers/i2c/busses/i2c-taos-evm.c | 8 +++++++-
 1 file changed, 7 insertions(+), 1 deletion(-)

diff --git a/drivers/i2c/busses/i2c-taos-evm.c b/drivers/i2c/busses/i2c-taos-evm.c
index 4c7fc2d..f673f5d 100644
--- a/drivers/i2c/busses/i2c-taos-evm.c
+++ b/drivers/i2c/busses/i2c-taos-evm.c
@@ -130,7 +130,13 @@ static int taos_smbus_xfer(struct i2c_adapter *adapter, u16 addr,
 			return 0;
 	} else {
 		if (p[0] == 'x') {
-			data->byte = simple_strtol(p + 1, NULL, 16);
+			/*
+			 * voluntarily dropping error code of kstrtou8 since all
+			 * error code that it could return are invalid according
+			 * to Documentation/i2c/fault-codes
+			 */
+			if (kstrtou8(p + 1, 16, &data->byte))
+				return -EPROTO;
 			return 0;
 		}
 	}
-- 
2.4.10

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

[PATCH v3 1/1] i2c: taos-evm: replace simple_strtoul by kstrtou8 LABBE Corentin <clabbe.montjoie@gmail.com> - 2015-11-18 14:00 +0100
  Re: [PATCH v3 1/1] i2c: taos-evm: replace simple_strtoul by kstrtou8 Andy Shevchenko <andy.shevchenko@gmail.com> - 2015-11-18 17:30 +0100
    Re: [PATCH v3 1/1] i2c: taos-evm: replace simple_strtoul by  kstrtou8 Jean Delvare <jdelvare@suse.de> - 2015-11-21 21:20 +0100
  Re: [PATCH v3 1/1] i2c: taos-evm: replace simple_strtoul by  kstrtou8 Jean Delvare <jdelvare@suse.de> - 2015-11-21 21:20 +0100

csiph-web