Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1274326
| From | Mark Brown <broonie@kernel.org> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH] ASoC: Atmel: ClassD: Set GCK's parent clock |
| Date | 2015-11-20 19:10 +0100 |
| Message-ID | <qwYid-2hb-11@gated-at.bofh.it> (permalink) |
| References | <qwoeL-3V4-29@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
[Multipart message — attachments visible in raw view] - view raw
On Thu, Nov 19, 2015 at 11:26:30AM +0800, Songjun Wu wrote:
> Set GCK's parent clock as audio clock, make
> sure the GCK's parent clock is audio clock.
> + ret = clk_set_parent(dd->gclk, dd->aclk);
> + if (ret) {
> + dev_err(dev, "failed to set GCK parent clock: %d\n", ret);
> + return ret;
> + }
Why are we doing this in the driver? This should be done by whatever
creates the clock tree, not by the driver that uses the clocks - that
way if some future SoC has a different clock tree the driver will
continue to work.
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH] ASoC: Atmel: ClassD: Set GCK's parent clock Songjun Wu <songjun.wu@atmel.com> - 2015-11-19 04:40 +0100
Re: [PATCH] ASoC: Atmel: ClassD: Set GCK's parent clock Mark Brown <broonie@kernel.org> - 2015-11-20 19:10 +0100
Re: [PATCH] ASoC: Atmel: ClassD: Set GCK's parent clock "Wu, Songjun" <songjun.wu@atmel.com> - 2015-11-23 04:10 +0100
csiph-web