Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1274207

Re: [PATCH 4/4] Documentation: usb: dwc3: qcom: Add TCSR mux usage

Show all headers | View raw

On Fri, Nov 20, 2015 at 09:08:46AM -0600, Felipe Balbi wrote:
> 
> Hi,
> 
> Andy Gross <agross@codeaurora.org> writes:
> > This patch adds documentation for the optional syscon-tcsr property in the
> > Qualcomm DWC3 node.  The syscon-tcsr specifies the register and bit used to
> > configure the TCSR USB phy mux register.
> >
> > Signed-off-by: Andy Gross <agross@codeaurora.org>
> > ---
> >  Documentation/devicetree/bindings/usb/qcom,dwc3.txt | 11 +++++++++++
> >  1 file changed, 11 insertions(+)
> >
> > diff --git a/Documentation/devicetree/bindings/usb/qcom,dwc3.txt b/Documentation/devicetree/bindings/usb/qcom,dwc3.txt
> > index ca164e7..dfa222d 100644
> > --- a/Documentation/devicetree/bindings/usb/qcom,dwc3.txt
> > +++ b/Documentation/devicetree/bindings/usb/qcom,dwc3.txt
> > @@ -8,6 +8,10 @@ Required properties:
> >    "core"		Master/Core clock, have to be >= 125 MHz for SS
> >  				operation and >= 60MHz for HS operation
> >  
> > +Optional properties:
> > +- syscon-tcsr	Specifies TCSR handle, register offset, and bit position for
> > +			configuring the phy mux setting.
> 
> oh, it's a PHY mux ? I don't think it should be part of any dwc3-* glue
> layer then. By the time we reach dwc3, the mux should be properly
> configured.
> 
> Kishon, any ideas ?
> 
> -- 
> balbi

The only issue with putting it at the phy layer is that i'd have redundant
syscon entries for each pair of phys, unless i group them somehow in dt.  The
only other issue I can think of is that in the downstream kernels, they do this
before messing with the configuration of the dwc3.  So long as the phys do their
thing before the dwc3 (phys latched before config), we're ok.



-- 
Qualcomm Innovation Center, Inc.
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
a Linux Foundation Collaborative Project

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH 0/4] Add QCOM DWC3 Phy support Andy Gross <agross@codeaurora.org> - 2015-11-20 09:40 +0100
  [PATCH 2/4] usb: dwc3: qcom: Configure TCSR phy mux register Andy Gross <agross@codeaurora.org> - 2015-11-20 09:40 +0100
    Re: [PATCH 2/4] usb: dwc3: qcom: Configure TCSR phy mux register Felipe Balbi <balbi@ti.com> - 2015-11-20 16:10 +0100
      Re: [PATCH 2/4] usb: dwc3: qcom: Configure TCSR phy mux register Andy Gross <agross@codeaurora.org> - 2015-11-20 17:00 +0100
  [PATCH 4/4] Documentation: usb: dwc3: qcom: Add TCSR mux usage Andy Gross <agross@codeaurora.org> - 2015-11-20 09:40 +0100
    Re: [PATCH 4/4] Documentation: usb: dwc3: qcom: Add TCSR mux usage Rob Herring <robh@kernel.org> - 2015-11-20 15:40 +0100
    Re: [PATCH 4/4] Documentation: usb: dwc3: qcom: Add TCSR mux usage Felipe Balbi <balbi@ti.com> - 2015-11-20 16:10 +0100
      Re: [PATCH 4/4] Documentation: usb: dwc3: qcom: Add TCSR mux usage Andy Gross <agross@codeaurora.org> - 2015-11-20 17:00 +0100
  [PATCH 3/4] ARM: dts: qcom: Add DWC3 USB support on IPQ8064 Andy Gross <agross@codeaurora.org> - 2015-11-20 09:40 +0100

csiph-web