Re: [PATCH] Fix a memory leak in scsi_host_dev_release()

From	Christoph Hellwig <hch@infradead.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH] Fix a memory leak in scsi_host_dev_release()
Date	2015-11-20 13:00 +0100
Message-ID	<qwSw9-6Id-15@gated-at.bofh.it> (permalink)
References	<qwSw9-6Id-17@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

Hi Bart,

the memory leak looks real, and your fix looks corret, but I still
don't like it.

I think it's reasonable for SCSI to assume that the final put_device
fully frees the struct device including the name pointer that is
assigned entirely behind the back of the caller.

So I think the fix for this probably should be in the driver core.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

Re: [PATCH] Fix a memory leak in scsi_host_dev_release() Christoph Hellwig <hch@infradead.org> - 2015-11-20 13:00 +0100
  Re: [PATCH] Fix a memory leak in scsi_host_dev_release() Christoph Hellwig <hch@infradead.org> - 2015-11-22 16:10 +0100

csiph-web