Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1273871

Re: [PATCH] clk: versatile: fix memory leak

Path csiph.com!eternal-september.org!feeder.eternal-september.org!feeds.phibee-telecom.net!news.panservice.it!bofh.it!news.nic.it!robomod
From Sudip Mukherjee <sudipm.mukherjee@gmail.com>
Newsgroups linux.kernel
Subject Re: [PATCH] clk: versatile: fix memory leak
Date Fri, 20 Nov 2015 10:00:04 +0100
Message-ID <qwPI0-4To-45@gated-at.bofh.it> (permalink)
References <qvsks-7Yr-65@gated-at.bofh.it> <qwjoJ-O1-9@gated-at.bofh.it>
X-Original-To Stephen Boyd <sboyd@codeaurora.org>
Dkim-Signature v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=date:from:to:cc:subject:message-id:references:mime-version :content-type:content-disposition:in-reply-to:user-agent; bh=9+krGPXoMfxZ2/DcgdURRa4bQ+zB43z87aM1AFep6pE=; b=1EMgwADRRHKLl11UV9tAdwEVBzy3jZVFv1xzUK5gf9nNS6aVOuFZKbapqGtMO7L7sE EnvCmmA1RhPHMjsXLk8j9jHs7uW1B4+nyshYR5jQ/yFPQnjCWfERqY0aSmWYrwC5MLPH q0CoLCo8X+w2lbXnVvRkT7YpinFyejXxAMAQT29aBDPHV6uo/AD2xjNEXwWgBZDmFpty EDIoq3QYgvKkV4wOmNKOBIxCU5xSTVRCG6iuxYHo3eJfkXG1cEPqd32suEe5c8k7RJry TgQMUHu680XXmDx4wu+TmxSsMmHpbalVelsryZR2S9EiVzOMvBuPZbQo3Jcr3ZS1zWU5 yjIg==
X-Received by 10.68.98.97 with SMTP id eh1mr17615121pbb.128.1448009900963; Fri, 20 Nov 2015 00:58:20 -0800 (PST)
MIME-Version 1.0
Content-Type text/plain; charset=us-ascii
Content-Disposition inline
User-Agent Mutt/1.5.21 (2010-09-15)
Sender robomod@news.nic.it
List-ID <linux-kernel.vger.kernel.org>
X-Mailing-List linux-kernel@vger.kernel.org
Approved robomod@news.nic.it
Lines 27
Organization linux.* mail to news gateway
X-Original-Cc Michael Turquette <mturquette@baylibre.com>, linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org
X-Original-Date Fri, 20 Nov 2015 14:28:15 +0530
X-Original-Message-ID <20151120085815.GB4485@sudip-pc>
X-Original-References <1447681600-14120-1-git-send-email-sudipm.mukherjee@gmail.com> <20151118222446.GG32672@codeaurora.org>
X-Original-Sender linux-kernel-owner@vger.kernel.org
Xref csiph.com linux.kernel:1273871

Show key headers only | View raw


On Wed, Nov 18, 2015 at 02:24:46PM -0800, Stephen Boyd wrote:
> On 11/16, Sudip Mukherjee wrote:
> > If of_clk_parent_fill() fails then we printed an error message and
> > returned. But we missed freeing sp810.
> > 
> > Signed-off-by: Sudip Mukherjee <sudip@vectorindia.org>
> > ---
> 
> Applied to clk-next

Thanks.
> 
> We don't need that error message on allocation failure either.

I sent another patch to remove the error message on kzalloc failure. Did
you mean that one or did you mean the error message for
of_clk_parent_fill()?
I could not find any message being printed if of_clk_parent_fill() fails
so kept it as it is.

regards
sudip
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | NextPrevious in thread | Next in thread | Find similar | Unroll thread


Thread

[PATCH] clk: versatile: fix memory leak Sudip Mukherjee <sudipm.mukherjee@gmail.com> - 2015-11-16 14:50 +0100
  Re: [PATCH] clk: versatile: fix memory leak Stephen Boyd <sboyd@codeaurora.org> - 2015-11-18 23:30 +0100
    Re: [PATCH] clk: versatile: fix memory leak Sudip Mukherjee <sudipm.mukherjee@gmail.com> - 2015-11-20 10:00 +0100
      Re: [PATCH] clk: versatile: fix memory leak Stephen Boyd <sboyd@codeaurora.org> - 2015-11-20 18:20 +0100

csiph-web