Re: [PATCH] clk: versatile: fix memory leak

From	Stephen Boyd <sboyd@codeaurora.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH] clk: versatile: fix memory leak
Date	2015-11-20 18:20 +0100
Message-ID	<qwXvP-1JB-11@gated-at.bofh.it> (permalink)
References	<qvsks-7Yr-65@gated-at.bofh.it> <qwjoJ-O1-9@gated-at.bofh.it> <qwPI0-4To-45@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On 11/20, Sudip Mukherjee wrote:
> On Wed, Nov 18, 2015 at 02:24:46PM -0800, Stephen Boyd wrote:
> > On 11/16, Sudip Mukherjee wrote:
> > > If of_clk_parent_fill() fails then we printed an error message and
> > > returned. But we missed freeing sp810.
> > > 
> > > Signed-off-by: Sudip Mukherjee <sudip@vectorindia.org>
> > > ---
> > 
> > Applied to clk-next
> 
> Thanks.
> > 
> > We don't need that error message on allocation failure either.
> 
> I sent another patch to remove the error message on kzalloc failure. Did
> you mean that one or did you mean the error message for
> of_clk_parent_fill()?

Yes I meant the one you removed. Thanks.

-- 
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] clk: versatile: fix memory leak Sudip Mukherjee <sudipm.mukherjee@gmail.com> - 2015-11-16 14:50 +0100
  Re: [PATCH] clk: versatile: fix memory leak Stephen Boyd <sboyd@codeaurora.org> - 2015-11-18 23:30 +0100
    Re: [PATCH] clk: versatile: fix memory leak Sudip Mukherjee <sudipm.mukherjee@gmail.com> - 2015-11-20 10:00 +0100
      Re: [PATCH] clk: versatile: fix memory leak Stephen Boyd <sboyd@codeaurora.org> - 2015-11-20 18:20 +0100

csiph-web