Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1273863

Re: [PATCH v4 03/13] drm/rockchip: return a true clock rate to adjusted_mode

Show all headers | View raw

On 2015年11月20日 16:15, Chris Zhong wrote:
> Since the mipi dsi driver need to use the clock of vop to make the
> calculation of Blanking. But sometimes the clock driver can not set a
> accurate clock_rate for vop, get it by clk_round_rate before mode_set,
> so we can get the true value.
>
> Signed-off-by: Chris Zhong <zyw@rock-chips.com>
>
> ---
>
> Changes in v4:
> use clk_round_rate to check the clock rate in vop_crtc_mode_fixup
>
> Changes in v3: None
> Changes in v2: None
>
>   drivers/gpu/drm/rockchip/rockchip_drm_vop.c | 5 +++++
>   1 file changed, 5 insertions(+)
>
> diff --git a/drivers/gpu/drm/rockchip/rockchip_drm_vop.c b/drivers/gpu/drm/rockchip/rockchip_drm_vop.c
> index 5d8ae5e..eff545b 100644
> --- a/drivers/gpu/drm/rockchip/rockchip_drm_vop.c
> +++ b/drivers/gpu/drm/rockchip/rockchip_drm_vop.c
> @@ -1136,9 +1136,14 @@ static bool vop_crtc_mode_fixup(struct drm_crtc *crtc,
>   				const struct drm_display_mode *mode,
>   				struct drm_display_mode *adjusted_mode)
>   {
> +	struct vop *vop = to_vop(crtc);
> +
>   	if (adjusted_mode->htotal == 0 || adjusted_mode->vtotal == 0)
>   		return false;
>   
> +	adjusted_mode->clock =
> +		clk_round_rate(vop->dclk, mode->clock * 1000) / 1000;
> +
>   	return true;
>   }
>   
Looks good for me, so
     Acked-by: Mark Yao <mark.yao@rock-chips.com>


-- 
Ｍark Yao


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH v4 0/13] Add mipi dsi support for rk3288 Chris Zhong <zyw@rock-chips.com> - 2015-11-20 09:20 +0100
  [PATCH v4 05/13] Documentation: dt-bindings: Add bindings for Synopsys DW MIPI DSI DRM bridge driver Chris Zhong <zyw@rock-chips.com> - 2015-11-20 09:20 +0100
    Re: [PATCH v4 05/13] Documentation: dt-bindings: Add bindings for  Synopsys DW MIPI DSI DRM bridge driver Rob Herring <robh@kernel.org> - 2015-11-20 15:40 +0100
  [PATCH v4 02/13] clk: rockchip: add mipidsi clocks on rk3288 Chris Zhong <zyw@rock-chips.com> - 2015-11-20 09:20 +0100
  [PATCH v4 07/13] drm: rockchip: Support Synopsys DesignWare MIPI DSI host controller Chris Zhong <zyw@rock-chips.com> - 2015-11-20 09:20 +0100
  [PATCH v4 01/13] clk: rockchip: add id for mipidsi sclk on rk3288 Chris Zhong <zyw@rock-chips.com> - 2015-11-20 09:20 +0100
    Re: [PATCH v4 01/13] clk: rockchip: add id for mipidsi sclk on rk3288 Heiko Stübner <heiko@sntech.de> - 2015-11-23 18:40 +0100
  [PATCH v4 06/13] drm/bridge: Add Synopsys DesignWare MIPI DSI host controller driver Chris Zhong <zyw@rock-chips.com> - 2015-11-20 09:20 +0100
    Re: [PATCH v4 06/13] drm/bridge: Add Synopsys DesignWare MIPI DSI  host controller driver Thierry Reding <treding@nvidia.com> - 2015-11-20 17:10 +0100
      Re: [PATCH v4 06/13] drm/bridge: Add Synopsys DesignWare MIPI DSI  host controller driver Chris Zhong <zyw@rock-chips.com> - 2015-11-26 08:10 +0100
        Re: [PATCH v4 06/13] drm/bridge: Add Synopsys DesignWare MIPI DSI  host controller driver Thierry Reding <treding@nvidia.com> - 2015-11-26 09:10 +0100
          Re: [PATCH v4 06/13] drm/bridge: Add Synopsys DesignWare MIPI DSI  host controller driver Chris Zhong <zyw@rock-chips.com> - 2015-11-26 11:10 +0100
  [PATCH v4 03/13] drm/rockchip: return a true clock rate to adjusted_mode Chris Zhong <zyw@rock-chips.com> - 2015-11-20 09:20 +0100
    Re: [PATCH v4 03/13] drm/rockchip: return a true clock rate to adjusted_mode Mark yao <mark.yao@rock-chips.com> - 2015-11-20 10:00 +0100
  [PATCH v4 08/13] Documentation: dt-bindings: Add bindings for rk3288 DW MIPI DSI driver Chris Zhong <zyw@rock-chips.com> - 2015-11-20 09:20 +0100

csiph-web