Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1273454

[PATH RESEND v2 03/10] tty: xuartps: Always enable transmitter in start_tx

From Soren Brinkmann <soren.brinkmann@xilinx.com>
Newsgroups linux.kernel
Subject [PATH RESEND v2 03/10] tty: xuartps: Always enable transmitter in start_tx
Date 2015-11-19 21:20 +0100
Message-ID <qwDQu-5IW-13@gated-at.bofh.it> (permalink)
References <qwDGO-5Ex-27@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw

start_tx must start transmitting characters. Regardless of the state of
the circular buffer, always enable the transmitter hardware.

Signed-off-by: Soren Brinkmann <soren.brinkmann@xilinx.com>
---
 drivers/tty/serial/xilinx_uartps.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/tty/serial/xilinx_uartps.c b/drivers/tty/serial/xilinx_uartps.c
index 2c98c357d9a0..df6778d17949 100644
--- a/drivers/tty/serial/xilinx_uartps.c
+++ b/drivers/tty/serial/xilinx_uartps.c
@@ -512,9 +512,6 @@ static void cdns_uart_start_tx(struct uart_port *port)
 {
 	unsigned int status, numbytes = port->fifosize;
 
-	if (uart_circ_empty(&port->state->xmit) || uart_tx_stopped(port))
-		return;
-
 	/*
 	 * Set the TX enable bit and clear the TX disable bit to enable the
 	 * transmitter.
@@ -524,6 +521,9 @@ static void cdns_uart_start_tx(struct uart_port *port)
 	status |= CDNS_UART_CR_TX_EN;
 	writel(status, port->membase + CDNS_UART_CR_OFFSET);
 
+	if (uart_circ_empty(&port->state->xmit) || uart_tx_stopped(port))
+		return;
+
 	while (numbytes-- && ((readl(port->membase + CDNS_UART_SR_OFFSET) &
 				CDNS_UART_SR_TXFULL)) != CDNS_UART_SR_TXFULL) {
 		/* Break if no more data available in the UART buffer */
-- 
2.6.3.3.g9bb996a

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATH RESEND v2 00/10] tty: xuartps: Fix lock ups Soren Brinkmann <soren.brinkmann@xilinx.com> - 2015-11-19 21:20 +0100
  [PATH RESEND v2 03/10] tty: xuartps: Always enable transmitter in start_tx Soren Brinkmann <soren.brinkmann@xilinx.com> - 2015-11-19 21:20 +0100
    Re: [PATH RESEND v2 03/10] tty: xuartps: Always enable transmitter in  start_tx Peter Hurley <peter@hurleysoftware.com> - 2015-11-20 13:20 +0100
      Re: [PATH RESEND v2 03/10] tty: xuartps: Always enable transmitter  in start_tx Sören Brinkmann <soren.brinkmann@xilinx.com> - 2015-11-20 16:30 +0100
        Re: [PATH RESEND v2 03/10] tty: xuartps: Always enable transmitter in  start_tx Peter Hurley <peter@hurleysoftware.com> - 2015-11-20 17:40 +0100
          Re: [PATH RESEND v2 03/10] tty: xuartps: Always enable transmitter  in start_tx Sören Brinkmann <soren.brinkmann@xilinx.com> - 2015-11-20 18:00 +0100
            Re: [PATH RESEND v2 03/10] tty: xuartps: Always enable transmitter in  start_tx Peter Hurley <peter@hurleysoftware.com> - 2015-11-20 18:20 +0100
              Re: [PATH RESEND v2 03/10] tty: xuartps: Always enable transmitter  in start_tx Sören Brinkmann <soren.brinkmann@xilinx.com> - 2015-11-20 18:30 +0100
              Re: [PATH RESEND v2 03/10] tty: xuartps: Always enable transmitter in  start_tx Michal Simek <michal.simek@xilinx.com> - 2015-11-23 08:10 +0100
                Re: [PATH RESEND v2 03/10] tty: xuartps: Always enable transmitter in  start_tx Peter Hurley <peter@hurleysoftware.com> - 2015-11-23 21:10 +0100
                Re: [PATH RESEND v2 03/10] tty: xuartps: Always enable transmitter in  start_tx Michal Simek <michal.simek@xilinx.com> - 2015-11-24 08:50 +0100
      Re: [PATH RESEND v2 03/10] tty: xuartps: Always enable transmitter  in start_tx Sören Brinkmann <soren.brinkmann@xilinx.com> - 2015-11-20 18:10 +0100
        Re: [PATH RESEND v2 03/10] tty: xuartps: Always enable transmitter in  start_tx Peter Hurley <peter@hurleysoftware.com> - 2015-11-20 18:20 +0100
  [PATH RESEND v2 05/10] tty: xuartps: Improve startup function Soren Brinkmann <soren.brinkmann@xilinx.com> - 2015-11-19 21:20 +0100
  [PATH RESEND v2 08/10] tty: xuartps: Move RX path into helper function Soren Brinkmann <soren.brinkmann@xilinx.com> - 2015-11-19 21:20 +0100
  [PATH RESEND v2 06/10] tty: xuartps: Keep lock for whole ISR Soren Brinkmann <soren.brinkmann@xilinx.com> - 2015-11-19 21:20 +0100
  [PATH RESEND v2 09/10] tty: xuartps: Only handle RX IRQs when RX is enabled Soren Brinkmann <soren.brinkmann@xilinx.com> - 2015-11-19 21:20 +0100
  [PATH RESEND v2 10/10] tty: xuartps: Cleanup: Reformat if-else Soren Brinkmann <soren.brinkmann@xilinx.com> - 2015-11-19 21:20 +0100
  [PATH RESEND v2 07/10] tty: xuartps: Acquire port lock for shutdown Soren Brinkmann <soren.brinkmann@xilinx.com> - 2015-11-19 21:20 +0100
  [PATH RESEND v2 01/10] tty: xuartps: Beautify read-modify writes Soren Brinkmann <soren.brinkmann@xilinx.com> - 2015-11-19 21:20 +0100
  [PATH RESEND v2 02/10] tty: xuartps: Use spinlock to serialize HW access Soren Brinkmann <soren.brinkmann@xilinx.com> - 2015-11-19 21:20 +0100

csiph-web