Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1273451

[PATH RESEND v2 00/10] tty: xuartps: Fix lock ups

Show all headers | View raw

Hi,

I guess this series got probably lost during the merge window. Hence, I
resend the patches.

This is v2, hopefully without any build issues. The changes are the same
as before, just the warning reported by kbuild test robot about unused
variables have been fixed. And, I added one more patch with some
cleanup/refactoring.

I recently found my system locking up under some conditions. I dug
through the code a bit and the result is this collections of various
changes. Some of it may not be required and has just been created out of
half-baked theories and re-reading the documentation. The actual failing
scenarios seem to be:
 - RX IRQ conditions are handled while the receiver is disabled, leaving
   the driver in an infinite loop
 - console_put_char seems to be interrupted by uart_shutdown disabling
   the transmitter while/just before printing

I.e. overall I tried to serialize all operations using the port lock to
avoid such interaction.

	Thanks,
	Sören

Sören Brinkmann (10):
  tty: xuartps: Beautify read-modify writes
  tty: xuartps: Use spinlock to serialize HW access
  tty: xuartps: Always enable transmitter in start_tx
  tty: xuartps: Clear interrupt status register in shutdown
  tty: xuartps: Improve startup function
  tty: xuartps: Keep lock for whole ISR
  tty: xuartps: Acquire port lock for shutdown
  tty: xuartps: Move RX path into helper function
  tty: xuartps: Only handle RX IRQs when RX is enabled
  tty: xuartps: Cleanup: Reformat if-else

 drivers/tty/serial/xilinx_uartps.c | 247 ++++++++++++++++++++-----------------
 1 file changed, 136 insertions(+), 111 deletions(-)

-- 
2.6.3.3.g9bb996a

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

[PATH RESEND v2 00/10] tty: xuartps: Fix lock ups Soren Brinkmann <soren.brinkmann@xilinx.com> - 2015-11-19 21:20 +0100
  [PATH RESEND v2 03/10] tty: xuartps: Always enable transmitter in start_tx Soren Brinkmann <soren.brinkmann@xilinx.com> - 2015-11-19 21:20 +0100
    Re: [PATH RESEND v2 03/10] tty: xuartps: Always enable transmitter in  start_tx Peter Hurley <peter@hurleysoftware.com> - 2015-11-20 13:20 +0100
      Re: [PATH RESEND v2 03/10] tty: xuartps: Always enable transmitter  in start_tx Sören Brinkmann <soren.brinkmann@xilinx.com> - 2015-11-20 16:30 +0100
        Re: [PATH RESEND v2 03/10] tty: xuartps: Always enable transmitter in  start_tx Peter Hurley <peter@hurleysoftware.com> - 2015-11-20 17:40 +0100
          Re: [PATH RESEND v2 03/10] tty: xuartps: Always enable transmitter  in start_tx Sören Brinkmann <soren.brinkmann@xilinx.com> - 2015-11-20 18:00 +0100
            Re: [PATH RESEND v2 03/10] tty: xuartps: Always enable transmitter in  start_tx Peter Hurley <peter@hurleysoftware.com> - 2015-11-20 18:20 +0100
              Re: [PATH RESEND v2 03/10] tty: xuartps: Always enable transmitter  in start_tx Sören Brinkmann <soren.brinkmann@xilinx.com> - 2015-11-20 18:30 +0100
              Re: [PATH RESEND v2 03/10] tty: xuartps: Always enable transmitter in  start_tx Michal Simek <michal.simek@xilinx.com> - 2015-11-23 08:10 +0100
                Re: [PATH RESEND v2 03/10] tty: xuartps: Always enable transmitter in  start_tx Peter Hurley <peter@hurleysoftware.com> - 2015-11-23 21:10 +0100
                Re: [PATH RESEND v2 03/10] tty: xuartps: Always enable transmitter in  start_tx Michal Simek <michal.simek@xilinx.com> - 2015-11-24 08:50 +0100
      Re: [PATH RESEND v2 03/10] tty: xuartps: Always enable transmitter  in start_tx Sören Brinkmann <soren.brinkmann@xilinx.com> - 2015-11-20 18:10 +0100
        Re: [PATH RESEND v2 03/10] tty: xuartps: Always enable transmitter in  start_tx Peter Hurley <peter@hurleysoftware.com> - 2015-11-20 18:20 +0100
  [PATH RESEND v2 05/10] tty: xuartps: Improve startup function Soren Brinkmann <soren.brinkmann@xilinx.com> - 2015-11-19 21:20 +0100
  [PATH RESEND v2 08/10] tty: xuartps: Move RX path into helper function Soren Brinkmann <soren.brinkmann@xilinx.com> - 2015-11-19 21:20 +0100
  [PATH RESEND v2 06/10] tty: xuartps: Keep lock for whole ISR Soren Brinkmann <soren.brinkmann@xilinx.com> - 2015-11-19 21:20 +0100
  [PATH RESEND v2 09/10] tty: xuartps: Only handle RX IRQs when RX is enabled Soren Brinkmann <soren.brinkmann@xilinx.com> - 2015-11-19 21:20 +0100
  [PATH RESEND v2 10/10] tty: xuartps: Cleanup: Reformat if-else Soren Brinkmann <soren.brinkmann@xilinx.com> - 2015-11-19 21:20 +0100
  [PATH RESEND v2 07/10] tty: xuartps: Acquire port lock for shutdown Soren Brinkmann <soren.brinkmann@xilinx.com> - 2015-11-19 21:20 +0100
  [PATH RESEND v2 01/10] tty: xuartps: Beautify read-modify writes Soren Brinkmann <soren.brinkmann@xilinx.com> - 2015-11-19 21:20 +0100
  [PATH RESEND v2 02/10] tty: xuartps: Use spinlock to serialize HW access Soren Brinkmann <soren.brinkmann@xilinx.com> - 2015-11-19 21:20 +0100

csiph-web