[PATCH] mfd: wm8994: Ensure that the whole MFD is built into a single module

Path	csiph.com!eternal-september.org!feeder.eternal-september.org!aioe.org!bofh.it!news.nic.it!robomod
From	Charles Keepax <ckeepax@opensource.wolfsonmicro.com>
Newsgroups	linux.kernel
Subject	[PATCH] mfd: wm8994: Ensure that the whole MFD is built into a single module
Date	Thu, 19 Nov 2015 18:10:02 +0100
Message-ID	<qwASC-3Lk-17@gated-at.bofh.it> (permalink)
X-Original-To	<lee.jones@linaro.org>
X-Mailer	git-send-email 1.7.2.5
MIME-Version	1.0
Content-Type	text/plain
X-Proofpoint-Spam-Details	rule=notspam policy=default score=0 spamscore=0 suspectscore=1 malwarescore=0 phishscore=0 adultscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1507310000 definitions=main-1511190279
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	38
Organization	linux.* mail to news gateway
X-Original-Cc	<linux-kernel@vger.kernel.org>, <pbrobinson@gmail.com>
X-Original-Date	Thu, 19 Nov 2015 16:46:14 +0000
X-Original-Message-ID	<1447951574-26253-1-git-send-email-ckeepax@opensource.wolfsonmicro.com>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	csiph.com linux.kernel:1273294

Show key headers only | View raw

The MFD part of wm8994 consists of three files wm8994-core.c,
wm8994-irq.c and wm8994-regmap.c only wm8994-core.c has a
MODULE_DESCRIPTION / LICENSE. These were clearly intended to be built
as a single module, but currently are not. This will lead to a tainted
kernel when loading modules for wm8894-irq.c and wm8994-regmap.c because
are missing a license.

This patch fixes this issue by grouping the three files together into a
single module.

Reported-by: Peter Robinson <pbrobinson@gmail.com>
Signed-off-by: Charles Keepax <ckeepax@opensource.wolfsonmicro.com>
---
 drivers/mfd/Makefile |    3 ++-
 1 files changed, 2 insertions(+), 1 deletions(-)

diff --git a/drivers/mfd/Makefile b/drivers/mfd/Makefile
index a8b76b8..99f93ab 100644
--- a/drivers/mfd/Makefile
+++ b/drivers/mfd/Makefile
@@ -61,7 +61,8 @@ wm8350-objs			:= wm8350-core.o wm8350-regmap.o wm8350-gpio.o
 wm8350-objs			+= wm8350-irq.o
 obj-$(CONFIG_MFD_WM8350)	+= wm8350.o
 obj-$(CONFIG_MFD_WM8350_I2C)	+= wm8350-i2c.o
-obj-$(CONFIG_MFD_WM8994)	+= wm8994-core.o wm8994-irq.o wm8994-regmap.o
+wm8994-objs			:= wm8994-core.o wm8994-irq.o wm8994-regmap.o
+obj-$(CONFIG_MFD_WM8994)	+= wm8994.o
 
 obj-$(CONFIG_TPS6105X)		+= tps6105x.o
 obj-$(CONFIG_TPS65010)		+= tps65010.o
-- 
1.7.2.5

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

[PATCH] mfd: wm8994: Ensure that the whole MFD is built into a single module Charles Keepax <ckeepax@opensource.wolfsonmicro.com> - 2015-11-19 18:10 +0100
  Re: [PATCH] mfd: wm8994: Ensure that the whole MFD is built into a  single module Peter Robinson <pbrobinson@gmail.com> - 2015-11-22 11:20 +0100
  Re: [PATCH] mfd: wm8994: Ensure that the whole MFD is built into a  single module Lee Jones <lee.jones@linaro.org> - 2015-11-23 17:30 +0100

csiph-web