Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1273294 > unrolled thread
| Started by | Charles Keepax <ckeepax@opensource.wolfsonmicro.com> |
|---|---|
| First post | 2015-11-19 18:10 +0100 |
| Last post | 2015-11-23 17:30 +0100 |
| Articles | 3 — 3 participants |
Back to article view | Back to linux.kernel
[PATCH] mfd: wm8994: Ensure that the whole MFD is built into a single module Charles Keepax <ckeepax@opensource.wolfsonmicro.com> - 2015-11-19 18:10 +0100
Re: [PATCH] mfd: wm8994: Ensure that the whole MFD is built into a single module Peter Robinson <pbrobinson@gmail.com> - 2015-11-22 11:20 +0100
Re: [PATCH] mfd: wm8994: Ensure that the whole MFD is built into a single module Lee Jones <lee.jones@linaro.org> - 2015-11-23 17:30 +0100
| From | Charles Keepax <ckeepax@opensource.wolfsonmicro.com> |
|---|---|
| Date | 2015-11-19 18:10 +0100 |
| Subject | [PATCH] mfd: wm8994: Ensure that the whole MFD is built into a single module |
| Message-ID | <qwASC-3Lk-17@gated-at.bofh.it> |
The MFD part of wm8994 consists of three files wm8994-core.c, wm8994-irq.c and wm8994-regmap.c only wm8994-core.c has a MODULE_DESCRIPTION / LICENSE. These were clearly intended to be built as a single module, but currently are not. This will lead to a tainted kernel when loading modules for wm8894-irq.c and wm8994-regmap.c because are missing a license. This patch fixes this issue by grouping the three files together into a single module. Reported-by: Peter Robinson <pbrobinson@gmail.com> Signed-off-by: Charles Keepax <ckeepax@opensource.wolfsonmicro.com> --- drivers/mfd/Makefile | 3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/drivers/mfd/Makefile b/drivers/mfd/Makefile index a8b76b8..99f93ab 100644 --- a/drivers/mfd/Makefile +++ b/drivers/mfd/Makefile @@ -61,7 +61,8 @@ wm8350-objs := wm8350-core.o wm8350-regmap.o wm8350-gpio.o wm8350-objs += wm8350-irq.o obj-$(CONFIG_MFD_WM8350) += wm8350.o obj-$(CONFIG_MFD_WM8350_I2C) += wm8350-i2c.o -obj-$(CONFIG_MFD_WM8994) += wm8994-core.o wm8994-irq.o wm8994-regmap.o +wm8994-objs := wm8994-core.o wm8994-irq.o wm8994-regmap.o +obj-$(CONFIG_MFD_WM8994) += wm8994.o obj-$(CONFIG_TPS6105X) += tps6105x.o obj-$(CONFIG_TPS65010) += tps65010.o -- 1.7.2.5 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[toc] | [next] | [standalone]
| From | Peter Robinson <pbrobinson@gmail.com> |
|---|---|
| Date | 2015-11-22 11:20 +0100 |
| Subject | Re: [PATCH] mfd: wm8994: Ensure that the whole MFD is built into a single module |
| Message-ID | <qxzUu-2li-7@gated-at.bofh.it> |
| In reply to | #1273294 |
Sorry for the delay in confirmation that it works. Tested-by: Peter Robinson <pbrobinson@gmail.com> On Thu, Nov 19, 2015 at 4:46 PM, Charles Keepax <ckeepax@opensource.wolfsonmicro.com> wrote: > The MFD part of wm8994 consists of three files wm8994-core.c, > wm8994-irq.c and wm8994-regmap.c only wm8994-core.c has a > MODULE_DESCRIPTION / LICENSE. These were clearly intended to be built > as a single module, but currently are not. This will lead to a tainted > kernel when loading modules for wm8894-irq.c and wm8994-regmap.c because > are missing a license. > > This patch fixes this issue by grouping the three files together into a > single module. > > Reported-by: Peter Robinson <pbrobinson@gmail.com> > Signed-off-by: Charles Keepax <ckeepax@opensource.wolfsonmicro.com> > --- > drivers/mfd/Makefile | 3 ++- > 1 files changed, 2 insertions(+), 1 deletions(-) > > diff --git a/drivers/mfd/Makefile b/drivers/mfd/Makefile > index a8b76b8..99f93ab 100644 > --- a/drivers/mfd/Makefile > +++ b/drivers/mfd/Makefile > @@ -61,7 +61,8 @@ wm8350-objs := wm8350-core.o wm8350-regmap.o wm8350-gpio.o > wm8350-objs += wm8350-irq.o > obj-$(CONFIG_MFD_WM8350) += wm8350.o > obj-$(CONFIG_MFD_WM8350_I2C) += wm8350-i2c.o > -obj-$(CONFIG_MFD_WM8994) += wm8994-core.o wm8994-irq.o wm8994-regmap.o > +wm8994-objs := wm8994-core.o wm8994-irq.o wm8994-regmap.o > +obj-$(CONFIG_MFD_WM8994) += wm8994.o > > obj-$(CONFIG_TPS6105X) += tps6105x.o > obj-$(CONFIG_TPS65010) += tps65010.o > -- > 1.7.2.5 > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[toc] | [prev] | [next] | [standalone]
| From | Lee Jones <lee.jones@linaro.org> |
|---|---|
| Date | 2015-11-23 17:30 +0100 |
| Subject | Re: [PATCH] mfd: wm8994: Ensure that the whole MFD is built into a single module |
| Message-ID | <qy2a8-4i0-55@gated-at.bofh.it> |
| In reply to | #1273294 |
On Thu, 19 Nov 2015, Charles Keepax wrote: > The MFD part of wm8994 consists of three files wm8994-core.c, > wm8994-irq.c and wm8994-regmap.c only wm8994-core.c has a > MODULE_DESCRIPTION / LICENSE. These were clearly intended to be built > as a single module, but currently are not. This will lead to a tainted > kernel when loading modules for wm8894-irq.c and wm8994-regmap.c because > are missing a license. > > This patch fixes this issue by grouping the three files together into a > single module. > > Reported-by: Peter Robinson <pbrobinson@gmail.com> > Signed-off-by: Charles Keepax <ckeepax@opensource.wolfsonmicro.com> > --- > drivers/mfd/Makefile | 3 ++- > 1 files changed, 2 insertions(+), 1 deletions(-) Applied, thanks. > diff --git a/drivers/mfd/Makefile b/drivers/mfd/Makefile > index a8b76b8..99f93ab 100644 > --- a/drivers/mfd/Makefile > +++ b/drivers/mfd/Makefile > @@ -61,7 +61,8 @@ wm8350-objs := wm8350-core.o wm8350-regmap.o wm8350-gpio.o > wm8350-objs += wm8350-irq.o > obj-$(CONFIG_MFD_WM8350) += wm8350.o > obj-$(CONFIG_MFD_WM8350_I2C) += wm8350-i2c.o > -obj-$(CONFIG_MFD_WM8994) += wm8994-core.o wm8994-irq.o wm8994-regmap.o > +wm8994-objs := wm8994-core.o wm8994-irq.o wm8994-regmap.o > +obj-$(CONFIG_MFD_WM8994) += wm8994.o > > obj-$(CONFIG_TPS6105X) += tps6105x.o > obj-$(CONFIG_TPS65010) += tps65010.o -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web