Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1270076

[PATCH 05/13] perf tools: Introduce strtobool() to string.c

Show all headers | View raw

This patch clones strtobool() from kernel's string.c to perf's string.c,
then add the function entry to tools/perf/util/include/linux/string.h.

string.h in perf utils doesn't have #ifdef guard. This patch fixes it.

This is preparation for enforcing BPF program configuration, which
would allow config string like 'inlines=yes'.

Signed-off-by: Wang Nan <wangnan0@huawei.com>
Cc: Alexei Starovoitov <ast@kernel.org>
Cc: Arnaldo Carvalho de Melo <acme@redhat.com>
Cc: Masami Hiramatsu <masami.hiramatsu.pt@hitachi.com>
Cc: Zefan Li <lizefan@huawei.com>
Cc: pi3orama@163.com
---
 tools/perf/util/include/linux/string.h |  5 +++++
 tools/perf/util/string.c               | 28 ++++++++++++++++++++++++++++
 2 files changed, 33 insertions(+)

diff --git a/tools/perf/util/include/linux/string.h b/tools/perf/util/include/linux/string.h
index 6f19c54..2bb0057 100644
--- a/tools/perf/util/include/linux/string.h
+++ b/tools/perf/util/include/linux/string.h
@@ -1,3 +1,8 @@
+#ifndef PERF_LINUX_STRING_H_
+#define PERF_LINUX_STRING_H_
 #include <string.h>
 
 void *memdup(const void *src, size_t len);
+
+int strtobool(const char *s, bool *res);
+#endif
diff --git a/tools/perf/util/string.c b/tools/perf/util/string.c
index fc8781d..c7fd44d 100644
--- a/tools/perf/util/string.c
+++ b/tools/perf/util/string.c
@@ -396,3 +396,31 @@ out_err_overflow:
 	free(expr);
 	return NULL;
 }
+
+/**
+ * strtobool - convert common user inputs into boolean values
+ * @s: input string
+ * @res: result
+ *
+ * This routine returns 0 iff the first character is one of 'Yy1Nn0'.
+ * Otherwise it will return -EINVAL.  Value pointed to by res is
+ * updated upon finding a match.
+ */
+int strtobool(const char *s, bool *res)
+{
+	switch (s[0]) {
+	case 'y':
+	case 'Y':
+	case '1':
+		*res = true;
+		break;
+	case 'n':
+	case 'N':
+	case '0':
+		*res = false;
+		break;
+	default:
+		return -EINVAL;
+	}
+	return 0;
+}
-- 
1.8.3.4

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

[PATCH 05/13] perf tools: Introduce strtobool() to string.c Wang Nan <wangnan0@huawei.com> - 2015-11-16 13:50 +0100
  Re: [PATCH 05/13] perf tools: Introduce strtobool() to string.c Arnaldo Carvalho de Melo <acme@kernel.org> - 2015-11-16 15:20 +0100
    Re: [PATCH 05/13] perf tools: Introduce strtobool() to string.c Arnaldo Carvalho de Melo <acme@kernel.org> - 2015-11-16 15:50 +0100
      Re: [PATCH 05/13] perf tools: Introduce strtobool() to string.c Arnaldo Carvalho de Melo <acme@kernel.org> - 2015-11-16 17:00 +0100
  [tip:perf/core] tools: Clone the kernel's strtobool function tip-bot for Wang Nan <tipbot@zytor.com> - 2015-11-23 17:10 +0100

csiph-web