Re: [PATCH 1/2] clk: samsung: Don't build ARMv8 clock drivers on ARMv7

From	Chanwoo Choi <cw00.choi@samsung.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH 1/2] clk: samsung: Don't build ARMv8 clock drivers on ARMv7
Date	2015-11-16 04:10 +0100
Message-ID	<qvil4-1Kh-3@gated-at.bofh.it> (permalink)
References	<qvgVX-M3-5@gated-at.bofh.it> <qvgVX-M3-9@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

Hi,

On 2015년 11월 16일 10:36, Krzysztof Kozlowski wrote:
> Currently the Exynos5433 (ARMv8 SoC) clock driver depends on ARCH_EXYNOS
> so it is built also on ARMv7. This does not bring any kind of benefit.
> There won't be a single kernel image for ARMv7 and ARMv8 SoCs (like
> multi_v7 for ARMv7).
> 
> Instead build clock drivers only for respective SoC's architecture.
> 
> Signed-off-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
> ---
>  drivers/clk/samsung/Kconfig  | 13 +++++++++++++
>  drivers/clk/samsung/Makefile |  4 ++--
>  2 files changed, 15 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/clk/samsung/Kconfig b/drivers/clk/samsung/Kconfig
> index 84196ecdaa12..5f138fc4d84d 100644
> --- a/drivers/clk/samsung/Kconfig
> +++ b/drivers/clk/samsung/Kconfig
> @@ -2,6 +2,7 @@ config COMMON_CLK_SAMSUNG
>  	bool
>  	select COMMON_CLK
>  
> +# ARMv7 SoCs:
>  config S3C2410_COMMON_CLK
>  	bool
>  	select COMMON_CLK_SAMSUNG
> @@ -24,3 +25,15 @@ config S3C2443_COMMON_CLK
>  	bool
>  	select COMMON_CLK_SAMSUNG
>  
> +# ARMv8 SoCs:
> +config EXYNOS5433_COMMON_CLK
> +	bool
> +	depends on ARM64 || COMPILE_TEST
> +	default ARCH_EXYNOS
> +	select COMMON_CLK_SAMSUNG
> +
> +config EXYNOS7_COMMON_CLK
> +	bool
> +	depends on ARM64 || COMPILE_TEST
> +	default ARCH_EXYNOS
> +	select COMMON_CLK_SAMSUNG
> diff --git a/drivers/clk/samsung/Makefile b/drivers/clk/samsung/Makefile
> index 5f6833ea355d..a31332a24ef4 100644
> --- a/drivers/clk/samsung/Makefile
> +++ b/drivers/clk/samsung/Makefile
> @@ -10,11 +10,11 @@ obj-$(CONFIG_SOC_EXYNOS5250)	+= clk-exynos5250.o
>  obj-$(CONFIG_SOC_EXYNOS5260)	+= clk-exynos5260.o
>  obj-$(CONFIG_SOC_EXYNOS5410)	+= clk-exynos5410.o
>  obj-$(CONFIG_SOC_EXYNOS5420)	+= clk-exynos5420.o
> -obj-$(CONFIG_ARCH_EXYNOS)	+= clk-exynos5433.o
> +obj-$(CONFIG_EXYNOS5433_COMMON_CLK)	+= clk-exynos5433.o
>  obj-$(CONFIG_SOC_EXYNOS5440)	+= clk-exynos5440.o
>  obj-$(CONFIG_ARCH_EXYNOS)	+= clk-exynos-audss.o
>  obj-$(CONFIG_ARCH_EXYNOS)	+= clk-exynos-clkout.o
> -obj-$(CONFIG_ARCH_EXYNOS7)	+= clk-exynos7.o
> +obj-$(CONFIG_EXYNOS7_COMMON_CLK)	+= clk-exynos7.o
>  obj-$(CONFIG_S3C2410_COMMON_CLK)+= clk-s3c2410.o
>  obj-$(CONFIG_S3C2410_COMMON_DCLK)+= clk-s3c2410-dclk.o
>  obj-$(CONFIG_S3C2412_COMMON_CLK)+= clk-s3c2412.o
> 

Looks good to me.

Reviewed-by: Chanwoo Choi <cw00.choi@samsung.com>

Regards,
Chanwoo Choi
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Thread

[PATCH 0/2] arm64: EXYNOS: Consolidate Exynos7 symbol Krzysztof Kozlowski <k.kozlowski@samsung.com> - 2015-11-16 02:40 +0100
  [PATCH 1/2] clk: samsung: Don't build ARMv8 clock drivers on ARMv7 Krzysztof Kozlowski <k.kozlowski@samsung.com> - 2015-11-16 02:40 +0100
    Re: [PATCH 1/2] clk: samsung: Don't build ARMv8 clock drivers on ARMv7 Chanwoo Choi <cw00.choi@samsung.com> - 2015-11-16 04:10 +0100
    Re: [PATCH 1/2] clk: samsung: Don't build ARMv8 clock drivers on ARMv7 "pankaj.dubey" <pankaj.dubey@samsung.com> - 2015-11-17 05:40 +0100
      Re: [PATCH 1/2] clk: samsung: Don't build ARMv8 clock drivers on ARMv7 Krzysztof Kozlowski <k.kozlowski@samsung.com> - 2015-11-17 05:40 +0100
        Re: [PATCH 1/2] clk: samsung: Don't build ARMv8 clock drivers on ARMv7 Sylwester Nawrocki <s.nawrocki@samsung.com> - 2015-11-17 15:10 +0100
    Re: [1/2] clk: samsung: Don't build ARMv8 clock drivers on ARMv7 Alim Akhtar <alim.akhtar@samsung.com> - 2015-11-19 05:20 +0100
    Re: [PATCH 1/2] clk: samsung: Don't build ARMv8 clock drivers on ARMv7 Tomasz Figa <tomasz.figa@gmail.com> - 2015-11-19 05:20 +0100
      Re: [PATCH 1/2] clk: samsung: Don't build ARMv8 clock drivers on ARMv7 Krzysztof Kozlowski <k.kozlowski@samsung.com> - 2015-11-19 06:00 +0100
        Re: [PATCH 1/2] clk: samsung: Don't build ARMv8 clock drivers on ARMv7 Tomasz Figa <tomasz.figa@gmail.com> - 2015-11-19 10:20 +0100
          Re: [PATCH 1/2] clk: samsung: Don't build ARMv8 clock drivers on  ARMv7 Krzysztof Kozlowski <k.kozlowski@samsung.com> - 2015-11-19 10:50 +0100
          Re: [PATCH 1/2] clk: samsung: Don't build ARMv8 clock drivers on ARMv7 Sylwester Nawrocki <s.nawrocki@samsung.com> - 2015-11-19 12:10 +0100

csiph-web