Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1271567

Re: [PATCH 1/8] Documentation/spi/spidev_test.c: use one rx buffer

Show all headers | View raw

On Tuesday, November 17, 2015 05:41:56 PM Mark Brown wrote:
> On Tue, Nov 17, 2015 at 07:24:21AM -0800, Joshua Clayton wrote:
> 
> > default_rx and rx are needlessly different.
> > Use one buffer, local to transmit()
> 
> Why?  This isn't what I'd expect from black boxing the API, from a
> userspace point of view the transfer is atomic and in an ideal world
> we'd be able to do direct to/from memory transfers rather than memcpy()
> into kernel space which means that userspace should assume the transfers
> are going on simultaneously even if they don't currently.

The important thing here was to get rid of the default_rx buffer.
I just noticed that the output can be set up completely within the scope
of the transmit function, since the operands are global. But I would be
just as happy to set it up at the top level. I'll change this in V2

--
~Joshua Clayton
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH 1/8] Documentation/spi/spidev_test.c: use one rx buffer Joshua Clayton <stillcompiling@gmail.com> - 2015-11-17 16:30 +0100
  Re: [PATCH 1/8] Documentation/spi/spidev_test.c: use one rx buffer Mark Brown <broonie@kernel.org> - 2015-11-17 18:50 +0100
    Re: [PATCH 1/8] Documentation/spi/spidev_test.c: use one rx buffer Joshua Clayton <stillcompiling@gmail.com> - 2015-11-17 20:00 +0100

csiph-web