Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1271491
| From | Mark Brown <broonie@kernel.org> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH 1/8] Documentation/spi/spidev_test.c: use one rx buffer |
| Date | 2015-11-17 18:50 +0100 |
| Message-ID | <qvSyf-8a9-17@gated-at.bofh.it> (permalink) |
| References | <qvQmJ-6NX-7@gated-at.bofh.it> <qvQmJ-6NX-5@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
[Multipart message — attachments visible in raw view] - view raw
On Tue, Nov 17, 2015 at 07:24:21AM -0800, Joshua Clayton wrote: > default_rx and rx are needlessly different. > Use one buffer, local to transmit() Why? This isn't what I'd expect from black boxing the API, from a userspace point of view the transfer is atomic and in an ideal world we'd be able to do direct to/from memory transfers rather than memcpy() into kernel space which means that userspace should assume the transfers are going on simultaneously even if they don't currently.
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH 1/8] Documentation/spi/spidev_test.c: use one rx buffer Joshua Clayton <stillcompiling@gmail.com> - 2015-11-17 16:30 +0100
Re: [PATCH 1/8] Documentation/spi/spidev_test.c: use one rx buffer Mark Brown <broonie@kernel.org> - 2015-11-17 18:50 +0100
Re: [PATCH 1/8] Documentation/spi/spidev_test.c: use one rx buffer Joshua Clayton <stillcompiling@gmail.com> - 2015-11-17 20:00 +0100
csiph-web