Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1271514

Re: net-scm: Delete an unnecessary check before the function call "kfree"

From SF Markus Elfring <elfring@users.sourceforge.net>
Newsgroups linux.kernel
Subject Re: net-scm: Delete an unnecessary check before the function call "kfree"
Date 2015-11-17 19:10 +0100
Message-ID <qvSRC-8wu-47@gated-at.bofh.it> (permalink)
References (14 earlier) <mSsDN-4wa-63@gated-at.bofh.it> <mSsDN-4wa-65@gated-at.bofh.it> <mSsDN-4wa-33@gated-at.bofh.it> <qvRCc-7wq-51@gated-at.bofh.it> <qvS5b-7Xf-9@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


> Eric already mentioned that in some situations where it's critical,
> it actually slows down the code, i.e. you'll have an extra
> function call to get there and inside kfree() / kfree_skb() / etc,
> the test is actually marked as unlikely().

How do you think about to add similar annotations to any more
source code places?

Regards,
Markus
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | NextPrevious in thread | Next in thread | Find similar | Unroll thread


Thread

[PATCH] net-scm: Delete an unnecessary check before the function call  "kfree" SF Markus Elfring <elfring@users.sourceforge.net> - 2015-11-17 17:50 +0100
  Re: [PATCH] net-scm: Delete an unnecessary check before the function  call "kfree" Daniel Borkmann <daniel@iogearbox.net> - 2015-11-17 18:20 +0100
    Re: net-scm: Delete an unnecessary check before the function call  "kfree" SF Markus Elfring <elfring@users.sourceforge.net> - 2015-11-17 19:10 +0100
      Re: net-scm: Delete an unnecessary check before the function call  "kfree" Daniel Borkmann <daniel@iogearbox.net> - 2015-11-17 19:40 +0100
        Re: net-scm: Macro for special pattern? SF Markus Elfring <elfring@users.sourceforge.net> - 2015-11-18 08:50 +0100
          Re: net-scm: Macro for special pattern? Eric Dumazet <eric.dumazet@gmail.com> - 2015-11-18 13:50 +0100
  Re: [PATCH] net-scm: Delete an unnecessary check before the  function call "kfree" David Miller <davem@davemloft.net> - 2015-11-17 18:20 +0100

csiph-web