Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1271467

Re: [PATCH] net-scm: Delete an unnecessary check before the function call "kfree"

Show all headers | View raw

From: SF Markus Elfring <elfring@users.sourceforge.net>
Date: Tue, 17 Nov 2015 17:43:35 +0100

> From: Markus Elfring <elfring@users.sourceforge.net>
> Date: Tue, 17 Nov 2015 17:37:22 +0100
> 
> The kfree() function tests whether its argument is NULL and then
> returns immediately. Thus the test around the call is not needed.
> 
> This issue was detected by using the Coccinelle software.
> 
> Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>

STOP submitting this crap, NOW!

I told you I won't review nor apply these patches any more.

And ever worse, this one is BUGGY.

We're testing p->fp so we know if we can safely dereference
it or not.

You're adding an OOPS to the kernel.

This is why these mindless mechanical transformations are not
only often a waste of time, they are dangerous as well.

I am silently rejecting from patchwork, immediately, any and all
patches you submit of this nature.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] net-scm: Delete an unnecessary check before the function call  "kfree" SF Markus Elfring <elfring@users.sourceforge.net> - 2015-11-17 17:50 +0100
  Re: [PATCH] net-scm: Delete an unnecessary check before the function  call "kfree" Daniel Borkmann <daniel@iogearbox.net> - 2015-11-17 18:20 +0100
    Re: net-scm: Delete an unnecessary check before the function call  "kfree" SF Markus Elfring <elfring@users.sourceforge.net> - 2015-11-17 19:10 +0100
      Re: net-scm: Delete an unnecessary check before the function call  "kfree" Daniel Borkmann <daniel@iogearbox.net> - 2015-11-17 19:40 +0100
        Re: net-scm: Macro for special pattern? SF Markus Elfring <elfring@users.sourceforge.net> - 2015-11-18 08:50 +0100
          Re: net-scm: Macro for special pattern? Eric Dumazet <eric.dumazet@gmail.com> - 2015-11-18 13:50 +0100
  Re: [PATCH] net-scm: Delete an unnecessary check before the  function call "kfree" David Miller <davem@davemloft.net> - 2015-11-17 18:20 +0100

csiph-web